Port testinstall to docker+go - #1603
Merged
Merged
Conversation
tadaskay
requested review from
Waldz,
anjmao,
soffokl,
vkuznecovas and
zolia
as code owners
January 31, 2020 07:27
tadaskay
force-pushed
the
1545-test-install-script
branch
from
January 31, 2020 08:11
799fdd1 to
65ecef4
Compare
vkuznecovas
suggested changes
Jan 31, 2020
Waldz
reviewed
Jan 31, 2020
tadaskay
force-pushed
the
1545-test-install-script
branch
from
January 31, 2020 09:06
65ecef4 to
487a5c1
Compare
vkuznecovas
approved these changes
Jan 31, 2020
tadaskay
force-pushed
the
1545-test-install-script
branch
from
January 31, 2020 09:23
487a5c1 to
632383f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1603 +/- ##
======================================
Coverage 47.8% 47.8%
======================================
Files 289 289
Lines 11519 11519
======================================
Hits 5507 5507
Misses 5618 5618
Partials 394 394
Continue to review full report at Codecov.
|
stretchr/testify#808 is merged into master, but not yet released as of moment of writing. Updating to latest master version.
tadaskay
force-pushed
the
1545-test-install-script
branch
from
January 31, 2020 09:47
632383f to
7c074e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1545
Rewrote bash+vagrant to go+docker