fix(ensrainbow): decouple Docker build from dev-only skills tooling - #2319
fix(ensrainbow): decouple Docker build from dev-only skills tooling#2319shrugs wants to merge 1 commit into
Conversation
The image copied skills-npm.config.ts, .agents/, and scripts/ solely so the root `prepare` lifecycle (dev-only skill symlinking) wouldn't fail during pnpm install. That coupling is what broke the build in #2302. Skip the irrelevant prepare with --ignore-scripts and drop those three copies. The lockfile pins no built dependencies, so nothing else depends on install scripts here. No runtime or image-size change (921MB, unchanged); verified the image boots and /health returns ok.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
|
Warning Review limit reached
More reviews will be available in 43 minutes and 57 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR de-fragilizes the ENSRainbow Docker image build by removing its dependency on the monorepo’s dev-only skills tooling, which previously had to be copied into the image solely to satisfy the root prepare lifecycle during pnpm install.
Changes:
- Remove copying
skills-npm.config.ts,.agents/, andscripts/into the ENSRainbow image build context. - Run
pnpm installwith--ignore-scriptsto avoid triggering the rootpreparelifecycle during image builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Install dependencies. --ignore-scripts skips the root `prepare` lifecycle (dev-only skill | ||
| # symlinking via skills-npm + scripts/link-local-skills.mjs), which is irrelevant to a runtime | ||
| # image and would otherwise force copying skills-npm.config.ts, .agents/ and scripts/ into the | ||
| # build context. The lockfile pins no built dependencies, so nothing else relies on scripts here. |
The ENSRainbow image copied
skills-npm.config.ts,.agents/, andscripts/solely so the rootpreparelifecycle (dev-only skill symlinking via skills-npm +scripts/link-local-skills.mjs) would not fail duringpnpm install. That coupling is exactly what broke the build in #2302 — every change to the skills tooling risks silently breaking the ENSRainbow image.This skips the irrelevant
preparewith--ignore-scriptsand drops those three copies. The lockfile pins no built dependencies (pnpm.onlyBuiltDependenciesis empty), so nothing else depends on install scripts here.Validation
/healthreturns{"status":"ok"}, the entrypoint binds the HTTP server and starts the database download.main).Scope
Intentionally narrow — this de-fragilizes the existing selective-copy build. It does not switch ENSRainbow to the other apps'
COPY . .pattern (that nearly doubles the image to ~1.79GB) nor to apnpm deploy --prodbundle (blocked by the apps running TypeScript from source and importing workspace packages' source at runtime; tracked separately as a larger "run built JS in production images" initiative).