docs(omnigraph): use dperri.com for the Domain Resolver example - #2330
Conversation
Switch the Domain Resolver omnigraph example from jesse.base.eth to the DNS-imported (3DNS) name dperri.com, and regenerate its response from the alpha hosted instance.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 48 minutes and 14 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe ChangesDomain-resolver example name swap
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummarySwitches the Domain Resolver Omnigraph example subject from
Confidence Score: 5/5Purely documentation and example-data changes with no logic modifications; all three data files are mutually consistent. The change touches only an example constant, a vendored JSON variable, and a vendored JSON response. All three are consistent with each other and with the PR description. The deleted changesets described earlier iterations of the same example and their removal is intentional. No runtime logic, API contracts, or schema definitions are altered. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Domain Resolver Example\n(domain-resolver)"] --> B{Name Subject}
B -- "Before" --> C["jesse.base.eth\n(Basename / .base.eth)"]
B -- "After" --> D["dperri.com\n(DNS-imported via 3DNS)"]
C --> E["assigned: 0xc6d566…\neffective: 0xde9049…"]
D --> F["assigned: null\neffective: 0xf142b3…"]
F --> G["ENSIP-10 wildcard resolution\nwalks up the tree to find\neffective resolver"]
style D fill:#d4edda,stroke:#28a745
style C fill:#f8d7da,stroke:#dc3545
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["Domain Resolver Example\n(domain-resolver)"] --> B{Name Subject}
B -- "Before" --> C["jesse.base.eth\n(Basename / .base.eth)"]
B -- "After" --> D["dperri.com\n(DNS-imported via 3DNS)"]
C --> E["assigned: 0xc6d566…\neffective: 0xde9049…"]
D --> F["assigned: null\neffective: 0xf142b3…"]
F --> G["ENSIP-10 wildcard resolution\nwalks up the tree to find\neffective resolver"]
style D fill:#d4edda,stroke:#28a745
style C fill:#f8d7da,stroke:#dc3545
Reviews (3): Last reviewed commit: "chore: remove example and docs changeset..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Updates the Omnigraph “Domain Resolver” example to use a DNS-imported (3DNS) name (dperri.com) instead of jesse.base.eth, and refreshes the vendored example inputs/outputs used by the docs.
Changes:
- Switched the SDK’s
domain-resolverexample default variable todperri.com(with updated rationale comment). - Updated the docs’ vendored Omnigraph examples input (
examples.json) to match the new name. - Regenerated the docs’ vendored response for
domain-resolver(responses.json) to reflect the new target name’s resolver data.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ensnode-sdk/src/omnigraph-api/example-queries.ts | Changes the domain-resolver example default to dperri.com and updates the explanatory comment. |
| docs/ensnode.io/src/data/omnigraph-examples/examples.json | Updates the domain-resolver example variables to dperri.com. |
| docs/ensnode.io/src/data/omnigraph-examples/responses.json | Updates the vendored domain-resolver response (assigned resolver now null, effective resolver address updated). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Example-data and docs-only changes ship under docs: without changesets; these never should have been created.
|
@greptile review |
Summary
Switches the Domain Resolver Omnigraph example name from
jesse.base.ethto the DNS-imported (3DNS) namedperri.com, and regenerates its vendored response from thealphahosted instance.dperri.comkeeps the property that made the previous subject useful — its assigned and effective resolvers differ — while showcasing a DNS-imported name (assigned resolver isnull, effective resolver resolved via ENSIP-10).Changes
packages/ensnode-sdk/.../example-queries.ts—domain-resolverdefault variable →dperri.com(constant + rationale comment updated).docs/ensnode.io/.../omnigraph-examples/examples.json— vendoreddomain-resolvervariable updated to match.docs/ensnode.io/.../omnigraph-examples/responses.json—domain-resolverresponse regenerated fromapi.alpha.ensnode.io.The frozen
schema.graphql/snapshot.jsonare intentionally left untouched (the snapshot is pinned to the v1.15.2 release; only the single example's variable + response changed).