Skip to content

Lint workflow files in CI, and find the approvals affected by the broken approve-publication workflow #154

Open

Description

@neuromechanist

approve-publication.yml was rejected by GitHub from #136 (2026-10-15) until the fix in #153, because RUN_CANCELLED: ${{ cancelled() }} sat in a step env: where status functions are not allowed. GitHub refuses the whole file before any job runs ("This run likely failed because of a workflow file issue"), and every push since then showed a failed run of this workflow. Nothing in the repository's CI could catch it: the only checks are Python unit tests for the scripts.

actionlint 1.7.12 over the whole repository found exactly that one error (plus two shellcheck style notes in run-bids-validation.yml and run-prescreen.yml).

To do

  • Merge Fix approve-publication: cancelled() is not allowed in env #153 (the fix; verified by a workflow_dispatch with invalid inputs: the file is accepted and the run stops at input validation).
  • Add a CI job that runs actionlint on .github/workflows/** on pull requests and pushes (pin the version; start with the shellcheck integration off or the two style notes fixed, so the job is green and a real error turns it red).
  • Find out which approvals were affected: for 2026-10-15 to the merge of Fix approve-publication: cancelled() is not allowed in env #153, every repository_dispatch[approve-publication] from the Approve button on the website could not start this workflow. List the approval requests from that window in the NEMAR API and check how each one ended (run from a terminal, never started, or retried).
  • Check the other workflow files for status functions or contexts used where GitHub does not allow them in dispatch-triggered paths that no test exercises (actionlint is clean for them today).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions