Skip to content

Approve via admin repo publish when the CLI has it - #155

Merged
neuromechanist merged 2 commits into
mainfrom
fix/approve-repo-publish-path
Nov 18, 2026
Merged

neuromechanist merged 2 commits into
mainfrom
fix/approve-repo-publish-path

Conversation

@neuromechanist

Copy link
Copy Markdown
Member

nemar-cli 0.10.34 (release PR nemarOrg/nemar-cli#2205, change nemarOrg/nemar-cli#2199) moves nemar admin publish ... to nemar admin repo publish ...; the old top-level path becomes a stub that exits 1 without running anything. This workflow installs the CLI from npm (latest in production, dev on the dev environment) and ran nemar admin publish approve, so:

  • the dev environment's web Approve button already fails (npm dev carries the move);
  • production's would fail the moment 0.10.34 becomes latest.

This change asks the installed CLI whether nemar admin repo --help lists publish and uses admin repo publish approve if so, admin publish approve otherwise, so it works before and after the release. Same captured-help pattern as onboard-openneuro.yml. Comments and the resume hint are updated.

Tested:

  • probe against nemar-cli@0.10.33 picks admin publish approve
  • probe against nemar-cli@dev picks admin repo publish approve
  • nemar-cli@dev admin repo publish approve --help has --yes and --resume
  • actionlint clean
  • an approve dispatch on the dev environment after merge

Must merge before nemarOrg/nemar-cli#2205.

Drafted with AI assistance.

@neuromechanist

Copy link
Copy Markdown
Member Author

Round 1 review (one reviewer): no Critical, Important or Moderate findings. Suggestions applied in the latest commit: the probe now matches the publish command line (indented, whole word, color stripped) instead of any substring, so unpublish or a description cannot select a path the CLI lacks (rechecked against nemar-cli@0.10.33 and @dev); the SIGPIPE comment is fixed; run-prescreen.yml comments name nemar dataset publish status and nemar admin repo publish list. Kept on purpose: the "before CLI 0.10.34" hint, useful while both versions are in use. Rejected: probing admin repo publish approve --help, because on 0.10.33 Commander exits 0 with the parent help. actionlint is clean on approve-publication.yml; its one SC2016 note on run-prescreen.yml line 122 is already on main and untouched here.

Drafted with AI assistance.

@neuromechanist
neuromechanist merged commit d04e21f into main Nov 18, 2026
@neuromechanist
neuromechanist deleted the fix/approve-repo-publish-path branch November 18, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant