You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Approve via admin repo publish when the CLI has it - #155
nemar-cli 0.10.34 (release PR nemarOrg/nemar-cli#2205, change nemarOrg/nemar-cli#2199) moves nemar admin publish ... to nemar admin repo publish ...; the old top-level path becomes a stub that exits 1 without running anything. This workflow installs the CLI from npm (latest in production, dev on the dev environment) and ran nemar admin publish approve, so:
the dev environment's web Approve button already fails (npm dev carries the move);
production's would fail the moment 0.10.34 becomes latest.
This change asks the installed CLI whether nemar admin repo --help lists publish and uses admin repo publish approve if so, admin publish approve otherwise, so it works before and after the release. Same captured-help pattern as onboard-openneuro.yml. Comments and the resume hint are updated.
Tested:
probe against nemar-cli@0.10.33 picks admin publish approve
probe against nemar-cli@dev picks admin repo publish approve
nemar-cli@dev admin repo publish approve --help has --yes and --resume
actionlint clean
an approve dispatch on the dev environment after merge
Round 1 review (one reviewer): no Critical, Important or Moderate findings. Suggestions applied in the latest commit: the probe now matches the publish command line (indented, whole word, color stripped) instead of any substring, so unpublish or a description cannot select a path the CLI lacks (rechecked against nemar-cli@0.10.33 and @dev); the SIGPIPE comment is fixed; run-prescreen.yml comments name nemar dataset publish status and nemar admin repo publish list. Kept on purpose: the "before CLI 0.10.34" hint, useful while both versions are in use. Rejected: probing admin repo publish approve --help, because on 0.10.33 Commander exits 0 with the parent help. actionlint is clean on approve-publication.yml; its one SC2016 note on run-prescreen.yml line 122 is already on main and untouched here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nemar-cli 0.10.34 (release PR nemarOrg/nemar-cli#2205, change nemarOrg/nemar-cli#2199) moves
nemar admin publish ...tonemar admin repo publish ...; the old top-level path becomes a stub that exits 1 without running anything. This workflow installs the CLI from npm (latestin production,devon the dev environment) and rannemar admin publish approve, so:devcarries the move);latest.This change asks the installed CLI whether
nemar admin repo --helplistspublishand usesadmin repo publish approveif so,admin publish approveotherwise, so it works before and after the release. Same captured-help pattern asonboard-openneuro.yml. Comments and the resume hint are updated.Tested:
nemar-cli@0.10.33picksadmin publish approvenemar-cli@devpicksadmin repo publish approvenemar-cli@dev admin repo publish approve --helphas--yesand--resumeactionlintcleanMust merge before nemarOrg/nemar-cli#2205.
Drafted with AI assistance.