You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Zarr: MaxShield probe failure has no failure code #1139
is_maxshield_fif returns False when the FIF header probe itself throws (truncated download, missing split member), which routes the recording down the normal path where a genuinely shielded file then fails with a generic file_read_error. The function prints a warning naming the real cause, but that warning lives only in the run log; nothing links it to the persisted failure record, so the index and the callback show the opaque code.
That is the incompletely-closed tail of the incident ADR 0028 exists for: the MaxShield cause went unexplained across 396 recordings precisely because the surfaced code did not name it. A distinct code (maxshield_probe_failed) would make the explanation survive into the failure record.
The branch itself is now covered by a test (TestIsMaxShieldFif, added in #1137); this issue is about the verdict, not the coverage.
Activity
Zarr: scratch-sweep guard, probe code, claim (#1221)
neuromechanist commentedon Sep 3, 2026
Fixed in #1221 (dev commit 1867c27); ships with the next dev to main release.