Skip to content

Zarr: MaxShield probe failure has no failure code #1139

Closed

Description

@neuromechanist

is_maxshield_fif returns False when the FIF header probe itself throws (truncated download, missing split member), which routes the recording down the normal path where a genuinely shielded file then fails with a generic file_read_error. The function prints a warning naming the real cause, but that warning lives only in the run log; nothing links it to the persisted failure record, so the index and the callback show the opaque code.

That is the incompletely-closed tail of the incident ADR 0028 exists for: the MaxShield cause went unexplained across 396 recordings precisely because the surfaced code did not name it. A distinct code (maxshield_probe_failed) would make the explanation survive into the failure record.

The branch itself is now covered by a test (TestIsMaxShieldFif, added in #1137); this issue is about the verdict, not the coverage.

Found during the v0.9.9 release review (#1137).

Activity

  1. added a commit that references this issue on Sep 3, 2026
    1867c27
  2. neuromechanist commented on Sep 3, 2026

    @neuromechanist
    ContributorAuthor

    Fixed in #1221 (dev commit 1867c27); ships with the next dev to main release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions