Repository navigation
Give the github-conflict signup case its own ORCID - #1279
Merged
Merged
Conversation
📦 Package PreviewYour package is ready to test! bun install -g nemar-cli@PR1279Version: 🤖 Updated on each push. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
api-testfailed on the v0.9.16 release PR (#1276):Not a product bug.
/auth/signupchecks username, then email, then ORCID (#1254, ADR 0043), then GitHub. Every signup case intest/api.test.tspasses the same shared fixture iD0000-0002-1825-0097. That is harmless for the cases whose refusal fires before the ORCID gate, but this one has to get PAST it to reach the GitHub gate. As soon as any row on dev holds the shared iD, and any live profile test that links it leaves one behind, this case stops testing what it is named for and reports a conflict from the wrong gate.The status assertion still passed (both are 409); only the error string caught it.
Fix
Give this one case its own iD,
0000-0000-0000-0001.0000-0000is outside every range ORCID assigns, so the value denotes no real person, and no run can ever claim it: the request 409s on the GitHub gate before a row is written. Signup validates format only (ORCID_ID_RE), not the checksum, so no real iD is needed.Verification
Against the live dev worker, the exact CI target:
bunx biome check test/api.test.tsclean. (bun run lintcoverssrc/only, the same gap as website#313.)