Repository navigation
fix(onboard-openneuro): dedup-skip existing datasets (refs #450, #448) - #456
Merged
Merged
Conversation
parse-ids now pre-filters the matrix to skip any ds###### whose on###### counterpart already exists on nemarDatasets with non-empty contents. Empty shells (size==0, e.g. the #450 recovery state from run 25769577607) are still kept so operators can re-import after deleting them. Motivation: until #448 (proper 'update existing OpenNeuro dataset' command) lands, re-importing a live dataset clobbers state. Yesterday's run 25769577607 caught this on ds003800 and ds007315 — both had been successfully onboarded earlier, the re-attempt failed at git-annex S3 initremote because the bucket already carried the prior annex-uuid. The current importer's 'Dataset already exists, continuing...' path silently barrels through enough state to do damage; the cleaner fix is to never matrix-spawn for those IDs in the first place. Uses NEMAR_GITHUB_PAT (the existing workflow secret) because nemarDatasets dataset repos are private. Refs #450 #448
📦 Package PreviewYour package is ready to test! bun install -g nemar-cli@PR456Version: 🤖 Updated on each push. |
2 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`parse-ids` now pre-filters the matrix to skip any `ds######` whose `on######` counterpart already exists on `nemarDatasets` with non-empty contents. Empty shells (size==0, the #450 recovery state) are kept so operators can re-import after deletion.
Why
Until #448 (proper "update existing OpenNeuro dataset" command) lands, re-importing a live dataset clobbers state. Yesterday's run 25769577607 caught this on `ds003800` and `ds007315` — both had successful prior imports, the re-attempt failed at `git annex initremote` because the S3 bucket carried the prior annex-uuid. The current importer's "Dataset already exists, continuing..." path barrels through enough state to do damage. Cleaner to never matrix-spawn for those IDs.
Behaviour
Uses `NEMAR_GITHUB_PAT` (the existing workflow secret) because nemarDatasets dataset repos are private.
Test plan
Refs #450 #448