Skip to content

Phase 7: Make the publication pre-screen advisory (#756) - #764

Merged
neuromechanist merged 2 commits into
feature/issue-749-epic-import-robustnessfrom
feature/issue-756-phase7-advisory-prescreen
Jun 16, 2026
Merged

neuromechanist merged 2 commits into
feature/issue-749-epic-import-robustnessfrom
feature/issue-756-phase7-advisory-prescreen

Conversation

@neuromechanist

Copy link
Copy Markdown
Contributor

Summary

The publication pre-screen (#666) is advisory in practice — admins publish anyway — but presented as a hard block: /webhooks/prescreen-result flipped the request to status='blocked' + block_reason='prescreen_failed', emailed a "blocked" notice, and run-prescreen.yml opened a "Block:" issue on the dataset repo. That hard-block-that-isn't masked real blockers (BIDS-validation failure also uses status='blocked').

This makes the pre-screen a non-blocking advisory:

  • /webhooks/prescreen-result now records prescreen_status='concern' + prescreen_reasons (migration 0045), leaving status untouched (the request stays in the normal admin-review queue). No "blocked" email.
  • decidePrescreenOutcome's returned field renamed blocked → flagged (it only flags an advisory concern; the S3-authority logic from Phase 4: Fix validate-stage git-annex blind spot (annex sizes -> reach validated) #753 is unchanged).
  • Surfaced as a yellow "Pre-screen advisory" (with reasons) in nemar dataset publish status and nemar admin publish list — distinct from a red block, so real status='blocked' (BIDS) stays unambiguous and the admin sees concerns before approving.
  • Re-request clears prescreen_reasons.

Cross-repo: nemarDatasets/.github# drops the repo-issue step (the "red CI" flag); the workflow stays green.

Closes #756
Part of epic #749

Test plan

  • bun test (297 pass; renamed .blocked→.flagged in the Phase-4 decision tests + new no-mock tests: the advisory UPDATE leaves status='requested'/block_reason=NULL, the one-shot pending guard, the re-request prescreen_reasons reset); tsc + biome clean.
  • Gated live: request publication on a thin dataset → prescreen_status='concern' with reasons, request NOT blocked, no repo issue; CLI shows the yellow advisory; admin approve proceeds.

The pre-screen flipped the request to status='blocked'+block_reason=
prescreen_failed (a soft block admins overrode anyway) + emailed 'blocked' +
opened a 'Block:' repo issue -- masking real blockers (BIDS also uses
'blocked'). Make it a non-blocking advisory: /webhooks/prescreen-result now
records prescreen_status='concern' + prescreen_reasons (migration 0045),
leaving status untouched; no block email. decidePrescreenOutcome's field
renamed blocked->flagged (advisory, logic unchanged). Surfaced as a yellow
'Pre-screen advisory' in nemar dataset publish status + admin publish list.
Re-request clears prescreen_reasons. +no-mock tests (status stays 'requested',
one-shot, reset). 297 tests.
@github-actions

github-actions Bot commented Jun 16, 2026 •

Copy link
Copy Markdown

📦 Package Preview

Your package is ready to test!

bun install -g nemar-cli@PR764

Version: 0.8.53-PR764.054a2da
Commit: 054a2da


🤖 Updated on each push.

(1) issue_url '' -> NULL (|| not ??) so the column isn't dirtied now the
workflow sends empty. (2) warn on the one-shot no-op (duplicate callback).
(3) de-stale the legacy prescreen_failed BLOCK_MESSAGE (no repo issue anymore).
(4) log malformed prescreen_reasons; clear prescreen_reasons on the dispatch
pending-set too; type the admin query's prescreen fields. +passed-branch
(status-untouched + one-shot) and reasons-parse-guard tests.
@neuromechanist
neuromechanist merged commit 3d5ed21 into feature/issue-749-epic-import-robustness Jun 16, 2026
1 check passed
@neuromechanist
neuromechanist deleted the feature/issue-756-phase7-advisory-prescreen branch June 16, 2026 23:56

This branch was previously deployed

1 inactive deployment
npm — 054a2dac Deployed Jun 16, 2026 by neuromechanist via publish #1415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant