Repository navigation
Phase 7: Make the publication pre-screen advisory (#756) - #764
Merged
neuromechanist merged 2 commits intoJun 16, 2026
Conversation
The pre-screen flipped the request to status='blocked'+block_reason= prescreen_failed (a soft block admins overrode anyway) + emailed 'blocked' + opened a 'Block:' repo issue -- masking real blockers (BIDS also uses 'blocked'). Make it a non-blocking advisory: /webhooks/prescreen-result now records prescreen_status='concern' + prescreen_reasons (migration 0045), leaving status untouched; no block email. decidePrescreenOutcome's field renamed blocked->flagged (advisory, logic unchanged). Surfaced as a yellow 'Pre-screen advisory' in nemar dataset publish status + admin publish list. Re-request clears prescreen_reasons. +no-mock tests (status stays 'requested', one-shot, reset). 297 tests.
📦 Package PreviewYour package is ready to test! bun install -g nemar-cli@PR764Version: 🤖 Updated on each push. |
(1) issue_url '' -> NULL (|| not ??) so the column isn't dirtied now the workflow sends empty. (2) warn on the one-shot no-op (duplicate callback). (3) de-stale the legacy prescreen_failed BLOCK_MESSAGE (no repo issue anymore). (4) log malformed prescreen_reasons; clear prescreen_reasons on the dispatch pending-set too; type the admin query's prescreen fields. +passed-branch (status-untouched + one-shot) and reasons-parse-guard tests.
neuromechanist
merged commit Jun 16, 2026
3d5ed21
into
feature/issue-749-epic-import-robustness
1 check passed
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The publication pre-screen (#666) is advisory in practice — admins publish anyway — but presented as a hard block:
/webhooks/prescreen-resultflipped the request tostatus='blocked'+block_reason='prescreen_failed', emailed a "blocked" notice, andrun-prescreen.ymlopened a "Block:" issue on the dataset repo. That hard-block-that-isn't masked real blockers (BIDS-validation failure also usesstatus='blocked').This makes the pre-screen a non-blocking advisory:
/webhooks/prescreen-resultnow recordsprescreen_status='concern'+prescreen_reasons(migration 0045), leavingstatusuntouched (the request stays in the normal admin-review queue). No "blocked" email.decidePrescreenOutcome's returned field renamedblocked→flagged(it only flags an advisory concern; the S3-authority logic from Phase 4: Fix validate-stage git-annex blind spot (annex sizes -> reach validated) #753 is unchanged).nemar dataset publish statusandnemar admin publish list— distinct from a red block, so realstatus='blocked'(BIDS) stays unambiguous and the admin sees concerns before approving.prescreen_reasons.Cross-repo: nemarDatasets/.github# drops the repo-issue step (the "red CI" flag); the workflow stays green.
Closes #756
Part of epic #749
Test plan
bun test(297 pass; renamed.blocked→.flaggedin the Phase-4 decision tests + new no-mock tests: the advisory UPDATE leavesstatus='requested'/block_reason=NULL, the one-shotpendingguard, the re-requestprescreen_reasonsreset);tsc+biomeclean.prescreen_status='concern'with reasons, request NOT blocked, no repo issue; CLI shows the yellow advisory; admin approve proceeds.