Repository navigation
Phase 3: Kill both legacy nemar.org couplings - #843
Merged
neuromechanist merged 2 commits intoJun 27, 2026
Merged
neuromechanist merged 2 commits into
neuromechanist merged 2 commits into
Conversation
Retire both directions of the legacy nemar.org/dataexplorer coupling (epic #837 Phase 3): - Incoming (catalog pull): delete catalog-sync.yml, catalog-sync.ts, and the POST /admin/catalog/sync + GET /admin/catalog/status endpoints. This is what folded the ds shadow rows (#748). - Outgoing (datapipeline push): delete nemar-sync.ts + nemar-sync-reference.md. Split out the 4 BIDS-tree helpers into bids-tree.ts (still used by the metadata pipeline) and the slim delete-only client into legacy-purge.ts (for the Phase 4 one-time purge). - Callers: publish sync_nemar step -> logged no-op (kept in allSteps); webhook post-version-DOI sync -> refreshDatasetMetadata (keeps the metadata-columns refresh, drops the nemar.org push); reindex runDatasetSync -> refreshDatasetMetadata; remove POST /admin/datasets/:id/sync, GET /admin/sync/status, the nemar admin sync CLI + api methods, and NEMAR_USERNAME/NEMAR_PASSWORD bindings. - Delete 5 legacy-sync test files; relocate helper-test imports to bids-tree. nemar_sync_* columns + catalog_sync_log table + CF secrets are dropped in Phase 5. Tested: backend + CLI typecheck, biome, affected unit tests green.
📦 Package PreviewYour package is ready to test! bun install -g nemar-cli@PR843Version: 🤖 Updated on each push. |
Review fixes (PR #843): delete the orphaned backend/test/version-doi-sync-trigger.test.ts (imported the removed shouldSyncToNemarAfterVersionDoi); wrap the 3 post-version-DOI refresh sites in refreshMetadataAfterVersionDoi so a pre-refresh throw (transient GitHub failure) records metadata_columns_error to D1 instead of only logging.
neuromechanist
merged commit Jun 27, 2026
77b8f0a
into
feature/issue-837-epic-legacy-separation
1 check passed
neuromechanist
deleted the
feature/issue-840-phase3-kill-legacy-couplings
branch
June 27, 2026 00:26
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 of epic #837. Removes both directions of the legacy
nemar.org/dataexplorercoupling in code.Incoming (catalog pull): deletes
catalog-sync.yml(4h cron),catalog-sync.ts, and thePOST /admin/catalog/sync+GET /admin/catalog/statusendpoints. This is the mechanism that folded the 183dsshadow rows (#748); after this they stop regenerating.Outgoing (datapipeline push): deletes
nemar-sync.ts+nemar-sync-reference.md. The file is split first:parseParticipantsTsv,countSessionDirs,countSubjectDirs,extractTasks) -> newbids-tree.ts(still used by the metadata pipeline).legacy-purge.ts(the one-time purge client for Phase 4).Callers:
sync_nemarstep -> logged no-op (kept inallSteps/PublicationStepso old DB records stay valid; mirrors the disabledupload_to_zenodo).refreshDatasetMetadata(preserves the metadata-columns refresh; drops only the nemar.org push) + removes theshouldSyncToNemarAfterVersionDoigate.runDatasetSyncrenamed torefreshDatasetMetadata(metadata-only); 2 callers updated.POST /admin/datasets/:id/sync,GET /admin/sync/status, thenemar admin sync run/statusCLI +syncDataset/getSyncStatusapi methods, andNEMAR_USERNAME/NEMAR_PASSWORDbindings.No prod mutation here (all code).
nemar_sync_*columns +catalog_sync_logtable + CF secrets are dropped in Phase 5; the legacy DB purge +dsdeletion run in Phase 4.Closes #840
Part of epic #837
Test plan
tsc --noEmitclean; CLItsc --noEmitclean.bids-tree.bun teston affected suites (dataset-metadata-columns, dataset-reindex, manifest-callback) green.