Skip to content

Phase 5: drop dead nemar_sync state + retire sync docs - #846

Merged
neuromechanist merged 2 commits into
feature/issue-837-epic-legacy-separationfrom
feature/issue-841-phase5-retire-ds-cleanup
Jun 27, 2026
Merged

neuromechanist merged 2 commits into
feature/issue-837-epic-legacy-separationfrom
feature/issue-841-phase5-retire-ds-cleanup

Conversation

@neuromechanist

Copy link
Copy Markdown
Contributor

Summary

Phase 5 of epic #837 — final cleanup of the now-dead legacy-sync remnants.

  • Migration 0053 drops datasets.nemar_sync_status/at/error (added in 0014) and the catalog_sync_log table (0018). Verified safe: no index/trigger/FK references these columns, and datasets_fts indexes only name/description/authors/tasks/modalities/readme. Validated on the SCCN dev D1 mirror before prod.
  • Remove the two dead nemar_sync_status reads from the GET /datasets queries (they were selected but never mapped to a response).
  • AGENTS.md: drop the nemar admin sync run/status commands + the datapipeline-sync docs; describe the legacy dataexplorer as being retired and DOIs landing on the canonical /dataset/<id>.

Intentionally kept: the (nm|on|ds) exact-id regex (after the ds rows are deleted, a ds lookup resolves to its on mirror via the source_id fallback — old bookmarks still work); and legacy-purge.ts + the Phase 4 one-off scripts (still needed for the post-deploy purge runs; removed in a final sweep after those run).

Cross-repo follow-up: drop the dataset_id LIKE 'on%' special-case in nemar-observability once the ds rows are purged.

Closes #841. Part of epic #837.

Test plan

  • Backend tsc --noEmit clean; biome clean; bun test on affected fixtures green.
  • Migration validated against the dev D1 mirror at epic finalize (before prod).

Epic #837 Phase 5. Remove the now-dead legacy-sync remnants:
- migration 0053 drops the nemar_sync_status/at/error columns (0014) and the
  catalog_sync_log table (0018); no index/trigger/FTS references them.
- remove the two dead nemar_sync_status reads from the GET /datasets queries.
- AGENTS.md: retire the nemar admin sync command + datapipeline-sync docs;
  describe the legacy site as being retired and DOIs landing on /dataset.
Keeps the (nm|on|ds) exact-id regex (ds bookmarks resolve to their on mirror via
source_id) and the legacy-purge.ts client + one-off scripts (needed for the
post-deploy purge runs). Cross-repo follow-up: nemar-observability LIKE 'on%'.
@github-actions

github-actions Bot commented Jun 27, 2026 •

Copy link
Copy Markdown

📦 Package Preview

Your package is ready to test!

bun install -g nemar-cli@PR846

Version: 0.8.70-PR846.3ccc429
Commit: 3ccc429


🤖 Updated on each push.

Review fix (PR #846): the 0053 column drop + SELECT removal made
dataset.nemar_sync_status always undefined, so the 'nemar dataset list' status
indicator would have shown a yellow * on every managed dataset. Remove the
indicator + the Dataset.nemar_sync_status field + the stale test-fixture column.
@neuromechanist
neuromechanist merged commit 4bd802f into feature/issue-837-epic-legacy-separation Jun 27, 2026
1 check passed
@neuromechanist
neuromechanist deleted the feature/issue-841-phase5-retire-ds-cleanup branch June 27, 2026 04:14

This branch was previously deployed

1 inactive deployment
npm — 3ccc429a Deployed Jun 27, 2026 by neuromechanist via publish #1589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant