Repository navigation
Phase 5: drop dead nemar_sync state + retire sync docs - #846
Merged
neuromechanist merged 2 commits intoJun 27, 2026
Conversation
Epic #837 Phase 5. Remove the now-dead legacy-sync remnants: - migration 0053 drops the nemar_sync_status/at/error columns (0014) and the catalog_sync_log table (0018); no index/trigger/FTS references them. - remove the two dead nemar_sync_status reads from the GET /datasets queries. - AGENTS.md: retire the nemar admin sync command + datapipeline-sync docs; describe the legacy site as being retired and DOIs landing on /dataset. Keeps the (nm|on|ds) exact-id regex (ds bookmarks resolve to their on mirror via source_id) and the legacy-purge.ts client + one-off scripts (needed for the post-deploy purge runs). Cross-repo follow-up: nemar-observability LIKE 'on%'.
📦 Package PreviewYour package is ready to test! bun install -g nemar-cli@PR846Version: 🤖 Updated on each push. |
Review fix (PR #846): the 0053 column drop + SELECT removal made dataset.nemar_sync_status always undefined, so the 'nemar dataset list' status indicator would have shown a yellow * on every managed dataset. Remove the indicator + the Dataset.nemar_sync_status field + the stale test-fixture column.
neuromechanist
merged commit Jun 27, 2026
4bd802f
into
feature/issue-837-epic-legacy-separation
1 check passed
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 5 of epic #837 — final cleanup of the now-dead legacy-sync remnants.
datasets.nemar_sync_status/at/error(added in 0014) and thecatalog_sync_logtable (0018). Verified safe: no index/trigger/FK references these columns, anddatasets_ftsindexes only name/description/authors/tasks/modalities/readme. Validated on the SCCN dev D1 mirror before prod.nemar_sync_statusreads from the GET /datasets queries (they were selected but never mapped to a response).nemar admin sync run/statuscommands + the datapipeline-sync docs; describe the legacy dataexplorer as being retired and DOIs landing on the canonical/dataset/<id>.Intentionally kept: the
(nm|on|ds)exact-id regex (after thedsrows are deleted, adslookup resolves to itsonmirror via thesource_idfallback — old bookmarks still work); andlegacy-purge.ts+ the Phase 4 one-off scripts (still needed for the post-deploy purge runs; removed in a final sweep after those run).Cross-repo follow-up: drop the
dataset_id LIKE 'on%'special-case innemar-observabilityonce thedsrows are purged.Closes #841. Part of epic #837.
Test plan
tsc --noEmitclean; biome clean;bun teston affected fixtures green.