Repository navigation
Phase 1: HED schema + projection plumbing - #874
Merged
neuromechanist merged 2 commits intoJun 30, 2026
Merged
neuromechanist merged 2 commits into
neuromechanist merged 2 commits into
Conversation
Contributor
Author
Review summary (3 agents: code, tests, comments — Sonnet)No critical or important issues in the code itself. All actionable findings addressed in Addressed
Skipped (with reason)
Local gates: 31 tests pass ( |
📦 Package PreviewYour package is ready to test! bun install -g nemar-cli@PR874Version: 🤖 Updated on each push. |
neuromechanist
merged commit Jun 30, 2026
558bf43
into
feature/issue-869-epic-hed-detection
1 check passed
This was referenced Jun 30, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lays the schema + read-path groundwork for per-version HED detection. Adds first-class HED columns and exposes them through the
/datasetsAPI, leaving them NULL until phase 2'sprobeHed()populates them. Mirrors channel/montage phase 1 (#857).0056_hed_columns.sql:datasetsADDhas_hed INTEGER,hed_version TEXT,hed_checked_at TEXT+idx_datasets_has_hed;dataset_versionsADDhas_hed INTEGER,hed_version TEXT. Per-version truth ondataset_versions; latest-version denormalized ontodatasetsfor single-table list filtering./datasetsprojection: projectd.has_hed,d.hed_versionin both the--minebrowse query and the main list query, next ton_channels/electrode_system. Raw (not COALESCE'd) so NULL = "not classified yet".No detection, writes, filter, or CLI here — those are phases 2-4. Columns stay NULL.
Closes #870
Part of epic #869
Test plan
backend/test/hed-columns-migration.test.ts(6 tests, realbun:sqlite, no mocks): asserts the new columns + index exist, round-trips a populated row, NULL semantics for unpopulated rows, and the per-version case (v1.0.0 null, v1.1.1 set).bun test test/migrations.test.tsstill green (no regression).bunx biome checkclean on changed files.bun run typecheck(backend) clean.