Repository navigation
Phase 1: prod-safety foundation for staging - #931
Merged
neuromechanist merged 2 commits intoJul 6, 2026
Merged
neuromechanist merged 2 commits into
neuromechanist merged 2 commits into
Conversation
Epic #923 (#930). All changes are no-ops/narrowing on prod: - migration 0057 adds is_exemplar column (inert until phases 4-5) - generateDatasetId gains a sandbox ID range partition; prod caps at xx089999 (SANDBOX_ID_CEILING), dev/test floors at xx090001 (SANDBOX_ID_FLOOR), so the shared nemarDatasets org can't collide - DEV_SANDBOX_RANGE_RE + isDevRangeDatasetId identify staging repos - POST /webhooks/github short-circuits dev-range repos on prod (no dispatch against staging repos whose callbacks 404 on prod) - POST /admin/datasets/import is production-only (on-id collisions) - sandbox upload size cap raised outside production - unit tests: partition (real D1) + webhook gate (real HMAC route)
- resolveRange() guards non-finite bounds with Number.isFinite so the clamp invariant holds at the function layer, not just via the caller; single source of truth for the allocator loop and exhaustion message - parseRangeBound warns on an unparseable SANDBOX_ID_* value instead of silently reverting to the full xx range - tests: function-level NaN/Infinity clamp; webhook gate leaves a prod-range xx (sandbox) repo below the ceiling untouched
Contributor
Author
Review (sonnet, pr-review-toolkit) — findings addressedFull backend suite green (424 tests, incl. 16 new for this phase); migration 0057 verified against a populated table; range math traced by hand for NaN/empty/negative/floor>ceiling/floor>cap. Addressed in a9df607:
No prod behavior change; every edit remains a no-op/narrowing on production. |
📦 Package PreviewYour package is ready to test! bun install -g nemar-cli@PR931Version: 🤖 Updated on each push. |
neuromechanist
merged commit Jul 6, 2026
df2b62a
into
feature/issue-923-epic-test-staging
1 check passed
This was referenced Jul 7, 2026
4 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foundation for the staging environment (epic #923). Every change is a no-op or narrowing on production; nothing here alters prod behavior, so it is safe to promote to `main` promptly ahead of the later phases.
Test plan
Closes #930
Part of epic #923