Repository navigation
Phase 1: serialize + gate backend deploys (#897) - #934
Merged
neuromechanist merged 2 commits intoJul 6, 2026
Merged
neuromechanist merged 2 commits into
neuromechanist merged 2 commits into
Conversation
Epic #896 Phase 1 (#897). Prod was double-deployed ungated: the dev->main merge commit and the auto-tag strip commit both match backend/** and fired migrate+deploy to production in parallel, racing tests. - concurrency group deploy-backend-${{ github.ref }} (cancel-in-progress:false) serializes deploys per ref; the two release commits now deploy sequentially. - new test-gate job (typecheck + lint + pure unit tests, mirroring test.yml's required tier); both deploy jobs needs: it, so a red build can't deploy. - post-deploy release-tag drift notice (git tag vs deployed commit).
📦 Package PreviewYour package is ready to test! bun install -g nemar-cli@PR934Version: 🤖 Updated on each push. |
Review found the gate was a no-op: deploy jobs have a custom if: (env check), which drops GitHub Actions' implicit needs-success gate, so a FAILED test-gate would not block the deploy. Add explicit needs.test-gate.result == 'success' to both deploy jobs.
Contributor
Author
Review (sonnet) — findings addressed in 8a40d3e
|
neuromechanist
merged commit Jul 6, 2026
ef02939
into
feature/issue-896-epic-arch-hardening
1 check passed
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the P0 where every release double-deploys production ungated (verified live 2026-07-02).
deploy-backend.ymlhad noconcurrency:and no test dependency, so the dev->main merge commit and auto-tag's strip commit (both matchbackend/**viapackage.json) firedwrangler d1 migrations apply+wrangler deployto prod in parallel, racing tests.concurrency: deploy-backend-${{ github.ref }}(cancel-in-progress: false) — the two release commits now deploy sequentially; a queued deploy waits rather than cancelling an in-flight prod migration.test-gatejob — typecheck + lint + pure unit tests (auto-classified identically totest.yml's requiredunit-puretier). Bothdeploy-devanddeploy-productionneeds:it, so a red build can't reach either environment.::notice::/::warning::on whether the deployed commit is a tagged release (git-tag vs running-Worker drift).Test plan
actionlintclean (only pre-existing SC2086 info notes on the untoucheddetect-environmentstep).test/workflow-yaml.test.tspasses (13 tests) — validates the workflow parses.test-gateruns for any dev/main push (environment != ''); deploy jobs are skipped if it fails (needs:).Closes #897
Part of epic #896