Repository navigation
Move live-network DOI/ORCID tests out of the required pure tier - #963
Merged
Merged
Conversation
test/doi-orcid-discovery.test.ts mixed deterministic offline tests with queryDataCiteDoi/discoverOrcidsFromReferencedDois tests that hit the live DataCite/Crossref APIs. The pure-tier classifier only excluded files matching testRequest|TEST_API_URL|runCli, so these network tests ran in unit-pure with the 5000ms default timeout and intermittently flaked (a real one blocked #961). Since #897 wired the pure tier into deploy-backend.yml's test-gate, that flake can also block a production deploy. Split the network tests into doi-orcid-discovery.integration.test.ts and teach all three classifiers a *.integration.test.ts convention: excluded from the required pure tier, run in the integration tier (--retry=2 --timeout 30000). Offline tests (24) stay pure; network tests (11) pass in integration.
3 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/doi-orcid-discovery.test.tsmixed deterministic offline tests (DOI extraction, creator matching) withqueryDataCiteDoi/discoverOrcidsFromReferencedDoistests that hit the live DataCite/Crossref APIs. The pure-tier classifier only excluded files matchingtestRequest|TEST_API_URL|runCli, so these network tests ran inunit-pureat the 5000ms default timeout and intermittently flaked — a real occurrence blocked release PR #961. Since #897 wired the pure tier intodeploy-backend.yml'stest-gate, that flake can also block a production deploy.Change
describeblocks intotest/doi-orcid-discovery.integration.test.ts.*.integration.test.tsconvention: excluded from the required/offline pure tier, included in the integration tier which already runs--retry=2 --timeout 30000.doi-orcid-discovery.test.tskeeps the 24 deterministic offline tests.Test plan
doi-orcid-discovery.test.ts-> pure,.integration.test.ts-> integration.biome check src/clean; both workflow YAMLs parse.Part of the dev->main release-safety hardening (#961).