Skip to content

Phase 3 (#11) needs rework against current epic architecture #21

Closed

Description

@neuromechanist

Background

PR #11 (Phase 3: Data quality + HED viz) was built against the epic state at c15a199's parent — before commits 1879a96 and c15a199 moved README + BIDS tree fetching off the page and into server-side /api/* endpoints.

A mechanical rebase produces an unresolvable conflict in src/pages/dataset/[id].astro:

HEAD (epic) imports: archiveZipUrl, getLanding, getMetadata, getDataset, resolveCanonical
Phase 3 imports:    archiveZipUrl, fetchGithubReadme, fetchManifestEntryText,
                    findReadmeEntry, getLanding, getManifest, getMetadata, buildTree

The Phase 3 commit ed373d8 weaves QualityPanel, FileVisModal, and FileViewModal into the old synchronous load path. Those data flows no longer exist on the page; resolving the conflict by keeping Phase 3's imports leaves orphaned functions that aren't called, and keeping the epic's imports leaves Phase 3's QualityPanel rendering broken.

What this issue is for

Track the rework required to land Phase 3 on current epic:

  1. Adapt QualityPanel and the file modals to fetch their data via the new /api/* endpoint pattern (same as README + BIDS tree)
  2. OR keep page-side rendering for QA but explicitly pass the new shapes
  3. OR add a new /api/qa/<id> endpoint that the QualityPanel client-renders against

Pick the approach that's most consistent with how the epic now handles deferred fetches.

Reference

  • Phase 3 branch: feature/issue-4-phase3-qa-hed
  • Last successful build/test: commit d3f62f0 (2026-05-15)
  • Components built but stranded: QualityPanel, PipelineSuccessChart, HistogramChart, AgeGenderChart, HedWordcloud, FileVisModal, FileViewModal
  • Test fixtures: test/fixtures/qa-*.json
  • QA data is live in S3 (we synced 31 datasets to s3://nemar/<on-id>/qa/ on 2026-05-18) and the worker route at data.nemar.org/<id>/qa/* serves it — the entire Phase 3 work just needs the page-side integration to match the new epic architecture.

Out of scope for this issue

Closing the original PR #11 is up to the reviewer; this issue tracks the rework regardless of whether the original PR stays open as a reference.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions