Skip to content

Signal viewer: open inline, with an enlarge-to-modal affordance #217

Closed

Description

@neuromechanist

Problem

website#199 / PR #206 moved the EEG/MEG/iEEG/EMG signal viewer out of the BIDS tree row and into a page-level full-screen modal, so every "eeg" preview button now opens a dialog immediately.

Opening straight into a modal is too heavy for what is usually a quick look at a recording. The inline placement reads better as a preview: it keeps the file's position in the tree visible, and it does not take over the page for a glance.

Wanted

  • Clicking a signal file opens the viewer inline, in the row's own preview panel, like the md/json/tsv previews do.
  • The inline panel carries an Enlarge control that promotes the same viewer into the existing full-screen dialog.
  • Closing the dialog returns the viewer to its inline panel.

The modal stays; it just stops being the entry point.

Constraints carried over from #206

  • One live viewer page-wide. The consolidation to a single shared instance in Modals: corner close button and full-screen EEG viewer #206 was not only about layout: a viewer per row accumulates WebGL contexts, and browsers cap those (~16). Opening a signal file must tear down whatever viewer was previously live.
  • Enlarge must not remount. A remount would discard the montage, filter, gain, channel page, and time window the user has set up, which is precisely the state they enlarged in order to look at more closely. Move the mounted subtree between hosts instead.
  • Preserve every existing failure path: zarrAvailable === "false" with its recorded zarrFailureReason plus download fallback, the mount-failure catch plus download fallback, and the aria-busy / data-loaded state markers.
  • Preserve the code-split dynamic import of lib/eeg-viewer/viewer.

Notes

mountEegViewer's MutationObserver watches document.documentElement (theme flips), not its host slot, and its ResizeObserver watches the viewer root inside the mounted subtree. Moving that subtree between an inline slot and the dialog is therefore safe: nothing triggers teardown, and the resize after the move repaints at the new width.

Related: #208 (superseded and closed mounts leave zarr fetches in flight).

Activity

  1. neuromechanist commented on Jul 31, 2026

    @neuromechanist
    ContributorAuthor

    Related follow-up: #223 adds a Comments section to the same dataset detail page, mirroring the dataset repository's GitHub issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions