You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Phase 3 file modals: Vis/View buttons in BIDS tree + FileVis/FileView dialogs #25
Tracking the second half of original Phase 3 (issue #4 / PR #11). The data-quality half (QualityPanel + charts) shipped via #24.
Scope
Per-file inspection from the BIDS tree:
Modify src/lib/render-tree.ts so leaf .set rows emit Vis and View action buttons with data-open-vis="<bids-path>" / data-open-view="<bids-path>" attributes. (Today the tree is rendered as a static string by render-tree.ts rather than as the Phase 3-era component-based BidsDirChildren.astro.)
Port FileVisModal.astro from the original Phase 3 branch (feature/issue-4-phase3-qa-hed, commit e374c50): a <dialog> showing the 4-stat strip + 5 SVG plots per file.
Port FileViewModal.astro: TSV preview (first 100 rows) with sticky header.
Mount both modals in [id].astro alongside QualityPanel.
Add a client-side script that:
Listens for clicks on [data-open-vis] / [data-open-view] inside the BidsTree placeholder
Fetches per-file data via getFileQa / TSV via direct manifest URL
Closing as superseded. Per-file inspection from the BIDS tree shipped, but by a different route than this issue specified, so none of the five steps above map onto the code as written.
What actually landed:
"View" half — BidsTree.astro renders each leaf as a .tree__preview-btn; clicking expands an inline preview that renders markdown, JSON, and TSV in place. No FileViewModal.astro, no data-open-view attribute, no 100-row cap.
"Vis" half — the Zarr-backed WebGL signal viewer (src/lib/eeg-viewer/), mounted into the page-level EegViewerDialog.astro. That is a live, scrubbing, montage-aware trace viewer with topomaps, not the five static SVG plots FileVisModal.astro was going to draw.
The reference implementation this issue pointed at is also no longer reachable in the shape described: src/lib/render-tree.ts was replaced by the component-based BidsTree.astro / BidsDirChildren.astro pair, so step 1 has no file to modify.
The one thing genuinely not delivered is the per-file QA stat strip (the 4 stats + quality plots). That depends on nemarOrg/nemar-cli#511 (/qa/* endpoint), which is still not started; src/lib/qa.ts and the fixtures under test/fixtures/ hold the contract for when it lands. Tracking that against #511 rather than keeping this issue open, since reviving it would mean re-specifying against components that no longer exist.
Activity
neuromechanist commentedon Jul 30, 2026
Closing as superseded. Per-file inspection from the BIDS tree shipped, but by a different route than this issue specified, so none of the five steps above map onto the code as written.
What actually landed:
BidsTree.astrorenders each leaf as a.tree__preview-btn; clicking expands an inline preview that renders markdown, JSON, and TSV in place. NoFileViewModal.astro, nodata-open-viewattribute, no 100-row cap.src/lib/eeg-viewer/), mounted into the page-levelEegViewerDialog.astro. That is a live, scrubbing, montage-aware trace viewer with topomaps, not the five static SVG plotsFileVisModal.astrowas going to draw.The reference implementation this issue pointed at is also no longer reachable in the shape described:
src/lib/render-tree.tswas replaced by the component-basedBidsTree.astro/BidsDirChildren.astropair, so step 1 has no file to modify.The one thing genuinely not delivered is the per-file QA stat strip (the 4 stats + quality plots). That depends on
nemarOrg/nemar-cli#511(/qa/*endpoint), which is still not started;src/lib/qa.tsand the fixtures undertest/fixtures/hold the contract for when it lands. Tracking that against #511 rather than keeping this issue open, since reviving it would mean re-specifying against components that no longer exist.