Skip to content

Zarr follow-ups from nemar-cli epic #1181: stale probe comment in store.ts, staging notes for zarr-test re-conversions #276

Closed

Description

@neuromechanist

Two small follow-ups surfaced while reviewing nemarOrg/nemar-cli#1181 (zarr serving next phase). Neither blocks that epic.

  1. src/lib/eeg-viewer/store.ts around the view-level discovery (the comment "The store has no level count attribute, so we probe") is stale: the code three lines below already prefers view_levels / n_view_levels from the channel-group attrs via declaredViewLevels and only probes when they are absent. biosigio (Zarr exporter: chunk view levels at a constant column count and declare the pyramid in attrs neuromechanist/biosigio#119, PR Citations on dataset pages: pill + modal, listing count, and dataset sorting #126) now writes both attrs on every group, so after the next NEMAR engine bump every store declares its pyramid and the probe is the legacy fallback. Update the comment, and consider treating an empty view_levels list as "declared, zero levels" rather than "not declared" so a very short recording does not trigger a probe.

  2. The staging data plane now carries real re-conversions: nemar-cli PR #1200 adds a --test profile to the Hallu converter that converts what nemar-db-dev marks public into s3://nemar-dev/<id>/zarr/, served by zarr-test.nemar.org (verified on xx099905). Until now zarr-test only held stores copied from production. Update the AGENTS.md staging section so contributors know zarr-test can exercise producer changes (chunk geometry, index format v3 from nemar-cli#1059) before they reach production.

A third, larger follow-up will be filed separately once the index carries the fields: a per-dataset coverage panel on the dataset page ("N of M recordings viewable; K failed by code; J pending") from index.json, per nemarOrg/nemar-cli#1197.

Activity

  1. neuromechanist commented on Sep 2, 2026

    @neuromechanist
    ContributorAuthor

    Fixed in #278 (merged into staging as b3027f4): an empty declared view_levels is treated as declared with zero probes, and the numeric n_view_levels/view_level_count zero case is covered too. Ships to production with the next staging promotion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions