Repository navigation
feat(discover): activate channel density + montage filter - #137
Merged
Merged
Conversation
Deploying nemar-website with
|
| Latest commit: |
8d10c42
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9d5714c.nemar-website.pages.dev |
| Branch Preview URL: | https://feature-activate-channel-mon.nemar-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Activates the previously-guarded Channels & montage filter on /discover, now that
api.nemar.orgreturnsn_channels+electrode_systemon every catalog row (nemar-cli#854, backfill converged on prod).n_channelsrange presets: Low (≤32), Standard (33–64), High (65–128), High-density (129+). URL paramdensity.es.listAllDatasets+needsClientPagingpath so the count and pager stay honest.Null-safety
applyClientFiltersdistinguishesundefined(reduced search projection — skip the predicate, can't evaluate) fromnull(known to have no scalp montage — excluded by a positive filter). Rawc_min/c_maxstill work for power users; the density preset takes precedence when both are set.Backend context
Consumer side of nemar-cli#854 (closed; feature delivered + prod backfill converged: 392/575 EEG-matching datasets classified). The residual unpopulated rows are diagnosed in nemar-cli#867 (iEEG predicate over-match, orphaned
nm0002xxrepo pointers, annexed/sparsechannels.tsv) — they correctly fall out of these filters as "no resolvable montage".Test plan
bun run test— 634 pass (added density/es URL round-trip +applyClientFiltersdensity/range/electrode/AND/undefined-guard cases)bun run typecheck— 0 errorsbun run lint— cleanbun run build— compilesAlso collapses one biome-reflowed line in
standard-montage.test.ts(pre-existing format debt from #136) to keep lint green.