Repository navigation
Release v0.2.2: drop the Community placeholder, mark outbound links - #225
Merged
Merged
Conversation
…ew tab (#224) * Drop Community; mark outbound links as new-tab The nav and footer advertised a Community surface backed by a placeholder page promising a forum that does not exist and was not being built. Nav entry, footer Forum link, and the page are gone; the footer column is now Project, describing what is actually under it. Links that leave nemar.org -- the citation dashboard, the docs site, the data/api hosts, the GitHub orgs, the build attribution -- now open in a new tab behind a 45-degree arrow. Not applied to download anchors, which also carry rel=external but start a download rather than a navigation. Also links the canonical /citations/ so visitors skip a 308 hop. Closes #222 * Reach nav and footer link styles into ExternalLink Astro scopes .primary-nav__list a to Nav's own elements, but the anchor renders inside ExternalLink.astro and carries that component's scope id instead -- so the rule missed it and Citation Dashboard and Documentation fell back to the default link colour and a larger size. Same in the footer columns. :global() on the descendant, scope kept on the container, so this stays confined to the nav and the footer nav.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
stagingto production. Prepared with Prepare release (0.2.2-dev1->0.2.2), so production never serves a-devNversion and test.nemar.org has already redeployed with this exact artifact.test.nemar.org:
0.2.2+5c58947b. Production:0.2.1+97fffd33.What ships
Community is gone (#222, PR #224)
The nav entry, the footer's "Forum" link, and
src/pages/community.astroare removed. The page was a placeholder saying a forum "will land in Phase 4" and pointing people atgithubproxy.fjygbaifeng.eu.org/nemarDatasetsin the meantime — a top-level nav slot spent on a surface with nothing behind it.The footer column is renamed Community -> Project, because it still holds About and Support and those are real; removing the column outright would have taken two working links with it.
/communitynow 404s. It was a stub with no inbound links from elsewhere on the site, so the exposure is bookmarks.The need it was standing in for — per-dataset discussion — is tracked as #223 with its backend in
nemar-cli#1043, now specified as a read-only mirror of each dataset repository's GitHub issues, populated by GitHub App webhooks with a daily reconcile.Outbound links open in a new tab, behind a 45-degree arrow
New
src/components/ExternalLink.astro, used for every nav and footer link that leaves nemar.org: the citation dashboard, the docs site, the Data column's three hosts, both GitHub organizations, and the Astro / Cloudflare Pages attribution.Deliberately not applied to every
rel="external"in the codebase. Download anchors — the BIDS tree's per-file links, the archive action — carryrel="external"too, and neither the arrow nortarget="_blank"belongs on them: they start a download rather than a navigation, so the arrow would promise a page that never appears.rel="noopener"is the part that matters withtarget="_blank"; without it the opened page gets a livewindow.openerhandle back. A visually-hidden "(opens in a new tab)" accompanies the icon, because a decorative arrow tells a sighted user what is about to happen and a screen-reader user nothing at all.Scoped-style fix caught in review
Astro scopes
.primary-nav__list ato Nav's own elements, but the anchor renders insideExternalLink.astroand carries that component's scope id — so the rule missed it and Citation Dashboard and Documentation fell back to the default link colour at a larger size. The footer columns had the same bug. Fixed with:global()on the descendant, scope kept on the container so it stays confined.One less redirect hop
dashboard.nemar.org/citations308s to/citations/. The nav, the footer, andgetRetiredRedirectall linked the non-canonical form, so every visitor paid an extra round trip — and from/citation-dashboardthat was a redirect landing on a redirect. All three now link/citations/.Verified on test.nemar.org
Against
0.2.2+5c58947b:/communityreturns 404; nav has five entries withtarget="_blank"on exactly the two external ones; footer headings are Explore / Project / Data / GitHub. Computed styles confirm internal and external links now match exactly —rgb(203, 213, 225)at14px, same weight, in both nav and footer.Nothing here touches
host.tshost dispatch, middleware routing, or canonical origins beyond the one redirect-target string, so the staging soak is representative despite website#212.test1015/1015,typecheck0 errors,lintclean,buildgreen on the release commit.Closes #222.