Repository navigation
cleanup: redact account id, drop orphan, log silent catches - #27
Merged
Merged
Conversation
Post-cutover hygiene pass per pr-review-toolkit findings on PR #26. - Replace literal SCCN account id in AGENTS.md/CLAUDE.md/.context/* with env-var references so the repo doesn't carry org-internal infra data as a hardcoded literal. Audit confirmed no actual credentials, emails, or tokens were tracked; only the account id was a literal. Deploy snippets now require CLOUDFLARE_ACCOUNT_ID exported in the shell. - Drop ProvenanceCard.astro -- superseded by ProvenanceToggle, no remaining imports. - Add console.warn context to four silent catches so worker outages, GitHub rate-limits, and catalog backend regressions leave triageable tail-log entries instead of silently degrading every detail page: - getDataset(id) catch in [id].astro - getQaAggregates(id) catch in [id].astro - fetchManifestEntryText catch in data-api.ts (manifest README path) - fetchGithubReadme catch in data-api.ts (AggregateError flattened into per-URL detail) - Update deploy branch reference in AGENTS.md from the epic branch to main now that the cutover has merged. 107/107 tests pass, typecheck clean, build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated hygiene pass after the epic cutover.
What's in
1. Move CF account ID out of tracked docs
Audit found no emails, IPs, or actual credentials; only the SCCN Cloudflare account id literal. Replaced everywhere with env-var references (`$CLOUDFLARE_ACCOUNT_ID` / `${CLOUDFLARE_ACCOUNT_ID:?...}`). Bumped AGENTS.md deploy snippet's --branch from the merged epic branch to main.
2. .context/ stays tracked, sanitized
Per policy decision: keep .context/handoff.md etc. tracked. Account-id redaction applied across all three files.
3. Drop orphaned ProvenanceCard.astro
Superseded by ProvenanceToggle; no remaining imports anywhere.
4. Log the four silent catches identified in PR #26 review
Each one used to swallow non-404 errors with no log, making backend outages indistinguishable from "dataset just has no data":
All warnings are prefixed `[component/path]` for greppability.
Out of scope
The discover-page UNION dedup for ds/on shadow pairs (just observed live -- the list endpoint still returns both ds002718 and on002718 etc.). That's a backend (nemar-cli list endpoint) concern, not a website fix; tracking separately.
Tests
107/107 pass, typecheck clean, biome clean, build clean.