Repository navigation
Release v0.2.9: CLI authorize page and Settings CLI keys - #320
Merged
Merged
Conversation
* feat: classify /cli as an app-host route * feat: device-auth client and view model * feat: add /cli/authorize page * feat: carry next through email verification * feat: add Settings CLI keys card and API routes * docs: AGENTS.md map, handoff, ADR 0016 * fix: no-store on every authorize response * fix: gate key reveal on a returned key * fix: dev store matches backend refusals * feat: log device-auth failures with reasons * test: review coverage for authorize and keys * docs: correct ADR 0016 attributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
stagingtomain. Opened with the-devNsuffix intact for the release automation to strip.Carries #317 (epic nemarOrg/nemar-cli#1272 phase 2): the
/cli/authorizepage on the app host that confirms or denies anemar auth loginfrom the CLI (pins the request origin, post-redirect-get, ADR 0016), the Settings "CLI keys" card (list per machine, create for a machine that cannot open a browser, revoke), andnextcarried through ORCID completion so a brand-new account returns to the authorize page.Release order
This merges FIRST, so
app.nemar.org/cli/authorizeis live before any released CLI prints its link. nemarOrg/nemar-cli's v0.10.0 release PR follows immediately after.Verification
Staging walk-through on test.nemar.org against api-test.nemar.org recorded on nemarOrg/nemar-cli#1272: device sign-in confirmed from a laptop and from a Docker container, expiry, keys shown once, revocation. Production check after deploy:
nemar auth loginfrom an admin machine printshttps://app.nemar.org/cli/authorize?code=...and completes.