Repository navigation
Lazy chunked dir tree + drop catalog-row SSR fetch - #79
Merged
Merged
Conversation
Deploying nemar-website with
|
| Latest commit: |
92432fa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc9f2f74.nemar-website.pages.dev |
| Branch Preview URL: | https://feature-issue-78-lazy-dir-pa.nemar-website.pages.dev |
Contributor
Author
Review pass — 3 sonnet agentscode-reviewer (pr-review-toolkit:code-reviewer)
silent-failure-hunter (pr-review-toolkit:silent-failure-hunter)
pr-test-analyzer (pr-review-toolkit:pr-test-analyzer)
374/374 tests green, lint clean, typecheck clean. Follow-up: #80 (drop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #78.
renderTopLevelnow emits only the first 50 directory rows on initial paint and appends a "Show next 50 (X of N shown)" footer when more remain. Click reveals the next 50 in place and updates the counter; the footer self-removes when all rows are visible. on005509 paints 50 sub-* rows + button instead of all 330+ at once. Files at the root (README, dataset_description.json, code/, …) still render in full — only the directory list is capped.api.nemar.org/datasets/<id>SSR fetch from the dataset detail page. With the post-#717 backfill (130/130 datasets at neuroschema 1.1),metadata.jsoncarries license / modalities / tasks / authors natively — the catalog-row's CSV-split fallbacks never trigger. Saves one api.nemar.org call per detail render and removes a contributor to the rate-limit pressure that triggered the 429 earlier today.getDataset()stays inlib/api.tsbecausedataset/[id]/collaborators.astrostill uses it.The tree's
<details>JSON listing endpoint, per-subdirectory lazy expand, and the discover / index pages' use ofapi.nemar.org/datasetsare unchanged.Test plan
bun run typecheck— 0 errors / 0 warningsbun run lint— biome cleanbun run test— 372 tests pass (5 new chunking + 4 newrenderDirChunkRowscases)bun run build— cleanon005509(330+ subjects): first paint shows 50 dirs + "Show next 50 (50 of 333 shown)". Clicking through reveals the rest in chunks of 50; footer removed after the final reveal. Per-subdirectory expand still fetchesdata.nemar.org/<id>/<v>/<path>/?format=json.performance.getEntriesByType('resource')confirms noapi.nemar.org/datasets/on005509browser request./browseagainst the Pages preview URL (cold isolate).