Repository navigation
A channel can run its agents on one named computer - #1306
Conversation
Channels hold any Place: local, boat, pool, or one computer by its place name (channels.sqlite3 v6 drops the word CHECKs). A computer the gateway does not serve now is refused channel_place_unavailable. The main agent may use the pool. Desktop channel settings and the new-channel flow list the connected computers; stress step `place` runs a channel's thread on a paired worker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JcBpmUavSQzUs5aJwmDfpv
The stress step reads the channel create answers; the place check runs under the creation lock against what the channel holds now; SSH hosts named like a kind word are not offered as computers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JcBpmUavSQzUs5aJwmDfpv
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JcBpmUavSQzUs5aJwmDfpv
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JcBpmUavSQzUs5aJwmDfpv
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 189569ff1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The architecture check keeps the desktop workspace model from importing the client SDK. channelPlaceWords names a computer the way the client names a place, so it moves to ui/channel-place-words.ts; the model keeps only the ChannelPlace type and channelPlaceKind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JcBpmUavSQzUs5aJwmDfpv
The step under test now goes through the surface a person uses, as the stress rules ask: the channel is chosen in the sidebar, ⌘N opens its home, and the message is typed and sent. The step checks the chat is listed in the channel, its lease is on the worker, and the window says where it runs. It goes back to the default channel before reopening the main conversation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JcBpmUavSQzUs5aJwmDfpv
|
The conversation stress job failed in one place: the WebKit-only This PR doesn't change the Devices page or its pairing flow. The only Devices code it touches is a read of I've re-run the failed job once. If it fails again, I'll treat it as this PR's and dig in. Generated by Claude Code |
Before: A channel's main agent and its threads could run only on This Mac, Boat, or (threads only) Any computer.
After: Either can also run on one named computer: an SSH host the gateway serves or a paired computer. Channel settings and the new-channel flow list those computers, and a computer the gateway does not serve is refused with
channel_place_unavailable.Closes #1305
Background
Slice P5 of the plan "Simplify where agents run". P1 (#1293) made one
Placetype, P2 (#1301) one rule that decides a new conversation's place, and P3 (#1303) trimmedEnvironmentsto places only. A channel keeps two places: one for its main agent (coordinator) and one for the threads it starts.The problem
local,boatandpool(SQLCHECKs), and the domain refusedpoolfor the main agent.poolcoming back for a main agent, and the phone's contract does not even listpoolfor threads.sequenceDiagram participant P as Person participant D as Desktop participant G as Gateway P->>D: open channel settings D-->>P: This Mac / Boat / Any computer only Note over P,D: devbox and paired Macs never offeredThe solution
sequenceDiagram participant P as Person participant D as Desktop participant G as Gateway participant W as Worker "devbox" D->>G: devices.list G-->>D: online workers + SSH hosts P->>D: Computer ▸ devbox (threads) D->>G: channel.setPlacement(threads = "devbox") G->>G: is devbox served? (under the channel lock) alt served G-->>D: ok, saved in channels.sqlite3 v6 P->>D: new chat in the channel G->>W: run it on devbox else not served G-->>D: channel_place_unavailable endChannelExecutionholds anyPlace. The wordslocal,boat,poolkeep their meaning; any other word must name an SSH host orpeer:<key>. The internal nameshere,peer:anyandboat:threadare refused. The main agent may now use the pool.channels-any-place.sqlrebuilds the three tables whose placement columns hadCHECKs and keeps every row.channel_place_unavailable. Generated Rust and TypeScript regenerated.channelPlaceWords(Local / Boat / Any computer / host name).place(6ec9311, 8e6a5b1, 189569f): pairs a worker, picks it for a channel's threads from the settings dialog, starts a chat in the channel and checks its lease is on that worker; also checks an unknown peer is refused.How we checked it
placealone, 20/20 held on latest main. The full gate runs in CI.devbox, and a service test where a channel names a served host and its new chats run there. The fullnessa-serverlib suite passed before the rebase; the 6 tests that need a non-root user fail on main too.devbox.-D warningson Linux, and on Windows through the mingw cross-check.Tradeoffs and follow-ups
Place::namedreads any plain word as a host, so"devbx"is refused aschannel_place_unavailable, not as an unknown word.poolfor threads already). That follows in nessa-ios once this merges.Rollout
The channel store upgrades itself from v5 to v6 on first open, in one transaction. Rolling back means restoring a v5
channels.sqlite3from backup, since older builds refuse a newer schema.Generated by Claude Code