Repository navigation
Validate immutable effective model capabilities - #26
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1e3ffe139
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Varuas37
pushed a commit
that referenced
this pull request
Nov 9, 2026
… lined up - #22 The Agents peek replies with the composer in its compact size (`.desktop-composer[data-size="compact"]`): same surface, Send at its usual size, instead of a pill of its own. - #23 The overview's first group starts right under its header, the list says Loading (kit LoadingText) until its rows are drawn, and a row is its title plus one line: an agent's command, or an app's who-asks-for-what. - #24 (kit) A trace never cuts the verb, cuts a path from its start, and draws a failed call's words in their usual tone. - #25 (kit) A table's copy button sits above its top-right corner. - #26 The access menu's right edge meets the composer's (kit `alignTo`). - #27 Every pane's composer has the same gutter (`--workspace-dock-gutter`, the 8px narrow-pane override is gone), and a home beside other panes is titled "New session". - #28 Jump to Latest sits on the composer's top edge, half over it, not on the last line of the reply. nessa-ui-revision pins nessa_ui ef3187f (branch head of nessa_ui#156). Stress: menu checks the access menu edge, the overview gap, two-line rows and the compact reply; table checks the copy button and Jump to Latest; window checks one gutter and the named home beside; trace checks the verb, the cut side and the failed row's tone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JcBpmVHPWxktA9QurvUMjM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A selected model's published capabilities do not describe what a configured binding can accept. Add immutable
EffectiveCapabilitiessnapshots that intersect model and binding support and reject configured token limits above either ceiling. For example, an image-capable model behind a text-only binding rejects image input before admission.TokenLimitsand its typed validation error live in the common domain, shared by metadata, binding declarations, and configured limits. No legacy export remains in model metadata.The pure domain validator checks explicit feature requirements and caller-supplied input/output budgets. Application DTOs project the same snapshot used for validation. No provider discovery, settings reader, authorization, or conversation lifecycle is introduced.
Validation:
A whole-workspace formatting check still reports pre-existing differences in untouched desktop files; the SDK formatting check passes. ACP compatibility and SQLite verification reports remain in their separate worktrees.
The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified.
Summary
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR M[Selected ModelMetadata] --> E[EffectiveCapabilities::new] B[BindingRestrictions] --> E C[Configured TokenLimits] --> E E -->|intersect features| S[Immutable EffectiveCapabilities] E -->|limits exceed either ceiling| CE[ConfiguredLimitExceeded] S --> V[validate requirements and budgets] R[Capability requirements] --> V T[Input tokens and reserved output] --> V V -->|supported and within limits| A[Admission succeeds] V -->|unsupported feature| U[Unsupported] V -->|invalid output budget| O[InvalidOutputBudget] V -->|input plus output exceeds window| W[ContextWindowExceeded] S --> D[EffectiveCapabilitiesDto projection]Reviews (1) · Last reviewed commit: "feat: validate immutable effective model..."