Skip to content

test: complete current conversation message fixtures - #865

Closed
Varuas37 wants to merge 1 commit into
mainfrom
codex/864-subscription-message-fixture
Closed

Varuas37 wants to merge 1 commit into
mainfrom
codex/864-subscription-message-fixture

Conversation

@Varuas37

@Varuas37 Varuas37 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Status

Superseded by #863, current head 242acc1d6bbec238c439560daecff5b37b86431e. This PR was not merged. Its fixture commit a3939f8a685f96e383b589af6fa82d145622baf9 is an ancestor of #863's branch, where the two current-contract test fixes now sit alongside the desktop question-target adapter fix. #863 closes #862 and #864.

Original scope and evidence

On this PR's fixture head a3939f8a685f96e383b589af6fa82d145622baf9, both successful synthetic ConversationMessage fixtures were updated with required_work_failed: None.

  • Affected subscription tests: 52/52.
  • Follow/close regression: 1/1.
  • Combined seven-package cargo test --no-run passed.
  • Removing either field independently reproduced E0063.
  • Rust format and diff checks passed.
  • Fresh independent review of this two-line change found no issues.

The first CI run on the standalone PR exposed the expected baseline mismatch: frontend typecheck reported the four old SDK-signature errors in the desktop question adapter/fake. Those are corrected in #863; the current #863 head has a new combined CI run and full-scope review in progress. The fixture integration is preserved in #863 through a normal merge commit.

Base: e6a7a88517f1907cbc92f93a6ca13a5a2d3fc4c7
Original head: a3939f8a685f96e383b589af6fa82d145622baf9
Superseding head: 242acc1d6bbec238c439560daecff5b37b86431e

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T09:32:00.500533Z a3939f8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1c781a71-4149-4d7a-81d0-eb6c9d4a9c4d
📥 Commits

Reviewing files that changed from the base of the PR and between e6a7a88 and a3939f8.

📒 Files selected for processing: 2
  • crates/nessa-client-core/tests/read_only_sync/gateway/session/subscribe.rs
  • crates/nessa-device-client/tests/session/follow_close.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

Two test fixtures now initialize ConversationMessage.required_work_failed to None.

Changes: Conversation fixture updates

Layer / File(s) Summary
Initialize required-work status in fixtures
crates/nessa-client-core/tests/read_only_sync/gateway/session/subscribe.rs, crates/nessa-device-client/tests/session/follow_close.rs
The blank and settled-view message fixtures set required_work_failed to None.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a3939

This test-only change initializes the optional field in both fixtures. The PR reports successful targeted tests and package compilation, with no production behavior change indicated.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly identifies the main change: completing current conversation message test fixtures.
Description check Passed The description explains that the PR was superseded, identifies the fixture changes, records test evidence, and provides commit references. The scripted gateway checks section is not required because …
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Varuas37

Copy link
Copy Markdown
Contributor Author

Closing this PR as superseded; it was not merged. Its fixture commit a3939f8 is now an ancestor of #863 head 242acc1, where both required_work_failed: None initializers are preserved with the #862 desktop question-target fix. #863 closes both #862 and #864. The 52/52 subscription tests, 1/1 follow/close test, combined seven-package no-run build, both E0063 revert probes, and clean fresh review were recorded on #865. The standalone run failed frontend typecheck on four baseline SDK-signature errors that #863 fixes; the combined #863 CI and full-scope review are pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate desktop question consumers to owner-issued SDK targets

1 participant