Skip to content

Settings: give native hooks their own privacy tab - #907

Merged
Varuas37 merged 6 commits into
mainfrom
codex/905-privacy-native-hooks-tab
Oct 15, 2026
Merged

Varuas37 merged 6 commits into
mainfrom
codex/905-privacy-native-hooks-tab

Conversation

@Varuas37

@Varuas37 Varuas37 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Closes #905. Privacy & Permissions opens on Access, whose existing browser contract keeps its common controls above the fold at 1000×700. Appending native hooks, remembered rules and review notifications made the last row end at y766. Unmodified main 102cff8c4 reproduces that exact failure in both Chromium and WebKit; #902's Settings sources are unchanged.

The structural problem is using the common first tab as the place to append every related feature. Native hooks already has its own component and gateway seam, so it can use the existing tab catalogue without a new abstraction.

Solution

  1. 09b3f538a: give native hooks a dedicated Privacy tab through the catalogue and exhaustive settingsTabPages mapping. Keep Access first and its default-access, remembered-rule and review-notification controls together. Preserve all hook warning text, configured/unavailable states and write/read behavior. The tab supplies its title, so its single group no longer repeats it.
  2. 09b3f538a: prove public catalogue/search routing and rendered placement. Extend existing browser hook checks to test absence on Access and both search destinations/row bounds; retain the existing fold budget and native-hook state checks.
  3. c7dc28080: update adjacent gateway/test comments found by fresh review.

Before

Access stacked four groups, making its last row fall below the fixed first-tab fold contract.

sequenceDiagram
  participant Catalogue as Settings catalogue
  participant Access as Privacy Access
  participant Hooks as Native hook rows
  participant Check as Masthead verifier
  Catalogue->>Access: Open common first tab
  Access->>Hooks: Render after defaults, rules and notifications
  Hooks-->>Check: Last row bottom 766 at height 700
  Check-->>Access: Fail fold contract
Loading

After

Access keeps its common controls. Native hooks has its own existing tab route; search uses that same catalogue identity to select and reveal either hook row.

sequenceDiagram
  participant Search as Settings search
  participant Catalogue as Settings catalogue
  participant Tabs as Privacy tabs
  participant Hooks as Native hook rows
  Search->>Catalogue: Find Claude Code hooks or Codex hooks
  Catalogue-->>Search: Native hooks tab and setting identity
  Search->>Tabs: Select Native hooks and reveal setting
  Tabs->>Hooks: Render existing warnings and gateway controls
Loading

Validation

Scoped browser/production evidence is from source 6936cf2fc on main base abdaed37c; a6127ec1b adds only the records and screenshots.

Check Result
Settings units 312/312
TypeScript, scoped ESLint, formatting Pass
Full Settings dev, Chromium + WebKit 23/23
Supported Settings production cases, both engines 17/17
Production smoke, both engines/layouts 33/33
Production Settings safe area/sidebar return 19/19
Restored both-engine masthead 3/3

Both engines measure Access's last row at y587 in the 1000×700 viewport. Both hook searches select Native hooks and reveal rows in view. The production arrival control is 220ms against the existing 300ms contract, with no reduced-motion animations; this is a duration check, not a frame-performance improvement claim.

Three separate unit probes fail when hook catalogue entries return to Access, the hook component returns to Access, or the redundant group heading returns. Restoring the source passes all 312 tests. A one-hunk browser probe reinserts only the hook component on Access, and the unchanged masthead check fails in both engines:

1000x700 Privacy & Permissions: a row ends at y=739, below the fold

Restoring the exact source passes 3/3. Historical base y766 includes the old group heading; the one-hunk probe does not reinstate it.

Fresh full source review at 6936cf2fc is clean at all priorities. The scoped evidence preserves commands/results, source attribution, baseline/probe records and environment limitations. All twelve current screenshots were visually inspected; historical access-* images remain unchanged.

The earlier unfiltered production run holds 17/23 because Rollup's desktop/index inputs omit the three fixture HTML cases per engine. Those states pass in the final dev run. The first dev attempt had 403s from prepared font links outside this checkout's Vite allowlist; local ignored font copies/links fixed the test environment. Both unsuccessful raw records are preserved, without product/configuration or console-filter changes.

Evidence-only follow-up 4b33ce52211f3a830957354e557604bf0885a707 formats baseline-settings-masthead.json and reinsert-probe.json for CI. Parsed values are identical to 4e306c6bd; production, verifier and fixture sources are unchanged. All PR-owned recognized files and all nine evidence JSON records pass scoped Prettier; diff-check passes. Codex completed without major findings at the preceding 4e306c6bd head; current-head CI/review are being checked separately.

User merged this PR as 4b7a2d001; the combined acceptance exceptions below remain tracked with #902. All ten workflow checks, current-head Codex and CodeRabbit are clean at 4b33ce522; local acceptance remains blocked by the exceptions below. The separate #902 full matrix had an MCP teardown failure whose original cause is unproved; these scoped checks do not diagnose it. Source history identifies the hook and remembered-rule additions (41d9a1d22, 79c2eca77), but the first failing historical commit has not been measured. Native WKWebView and arbitrary gateway rule-list sizes were not verified.

Screenshots

Access at 1000×700 now has all its common controls above the fold:

Access in Chromium

The existing hook controls and warning have their own tab:

Native hooks in WebKit

No typography, spacing budget, hook safety copy, runtime state, protocol or CI gate changes.

Combined acceptance status

The combined 32-program functional run completed at clean assembly 25e621b37 on main abdaed37, with #902 head 35bb18cf2 and #907 head 4e306c6bd (final #907 4b33ce522 only formats equivalent evidence JSON). It is not an acceptance pass: 29 programs held; mode-publication and panel-list-follow could not start because the assembly checkout lacked the built gateway binary; message-sync held 14/15 with one Chromium columns frame at 53.7ms against 50ms. Four retained-app checks were explicitly dev-only skips in its production sub-run. MCP apps 93/93, Settings 23/23 and user attachments 109/109 held. The failed records are preserved; the missing gateway checks, a headed measured control, retained-app coverage and signed-out scripted gateway verification are pending. No merge-ready claim is made. The original MCP teardown cause remains unproved.

Summary by CodeRabbit

  • Updates
    • Moved Claude and Codex hook settings from Access to a dedicated Privacy & Permissions › Native hooks tab. Access retains its common controls.
    • Hook settings remain disabled and have no switches when native hooks are unavailable. Searching for either setting now takes you to its row in the Native hooks tab.

Access grew beyond its 1000x700 first-tab contract after native hooks
and remembered rules were composed onto it. Reuse the existing typed
privacy tabs to keep common access controls together and leave hook
safety copy and lifecycle behavior intact.

Base 102cff8 reproduces y766 in both engines. History identifies additions
in 41d9a1d and 79c2eca; the first bad commit is not measured.

Refs #905
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e442879b-6be1-49d9-8852-bbd1d7e002a6
📥 Commits

Reviewing files that changed from the base of the PR and between 4e306c6 and 4b33ce5.

📒 Files selected for processing: 2
  • verification/desktop/evidence/905-privacy-tabs/baseline-settings-masthead.json
  • verification/desktop/evidence/905-privacy-tabs/reinsert-probe.json
 _____________________________________________________
< Your types are doing parkour to avoid being useful. >
 -----------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e675752e-b4ca-42ab-82b1-fb5a35d5c952
📥 Commits

Reviewing files that changed from the base of the PR and between abdaed3 and 4e306c6.

⛔ Files ignored due to path filters: 12
  • verification/desktop/evidence/905-privacy-tabs/privacy-access-chromium.png is excluded by !**/*.png
  • verification/desktop/evidence/905-privacy-tabs/privacy-access-webkit.png is excluded by !**/*.png
  • verification/desktop/evidence/905-privacy-tabs/privacy-native-hooks-chromium.png is excluded by !**/*.png
  • verification/desktop/evidence/905-privacy-tabs/privacy-native-hooks-webkit.png is excluded by !**/*.png
  • verification/desktop/evidence/settings-native-hooks/native-hooks-failed-chromium.png is excluded by !**/*.png
  • verification/desktop/evidence/settings-native-hooks/native-hooks-failed-webkit.png is excluded by !**/*.png
  • verification/desktop/evidence/settings-native-hooks/native-hooks-on-chromium.png is excluded by !**/*.png
  • verification/desktop/evidence/settings-native-hooks/native-hooks-on-webkit.png is excluded by !**/*.png
  • verification/desktop/evidence/settings-native-hooks/native-hooks-resting-chromium.png is excluded by !**/*.png
  • verification/desktop/evidence/settings-native-hooks/native-hooks-resting-webkit.png is excluded by !**/*.png
  • verification/desktop/evidence/settings-native-hooks/native-hooks-unset-chromium.png is excluded by !**/*.png
  • verification/desktop/evidence/settings-native-hooks/native-hooks-unset-webkit.png is excluded by !**/*.png
📒 Files selected for processing: 22
  • src/desktop/settings/adapters/native-hooks-gateway.ts
  • src/desktop/settings/index.ts
  • src/desktop/settings/model/settings-catalogue.test.ts
  • src/desktop/settings/model/settings-catalogue.ts
  • src/desktop/settings/ui/native-hooks-rows.test.tsx
  • src/desktop/settings/ui/native-hooks-rows.tsx
  • src/desktop/settings/ui/settings-tabs.tsx
  • src/desktop/settings/ui/settings-view.test.tsx
  • verification/desktop/CHECKLIST.md
  • verification/desktop/evidence/905-privacy-tabs/README.md
  • verification/desktop/evidence/905-privacy-tabs/baseline-settings-masthead.json
  • verification/desktop/evidence/905-privacy-tabs/initial-font-environment-failure.json
  • verification/desktop/evidence/905-privacy-tabs/reinsert-probe-source.diff
  • verification/desktop/evidence/905-privacy-tabs/reinsert-probe.json
  • verification/desktop/evidence/905-privacy-tabs/restored-masthead.json
  • verification/desktop/evidence/905-privacy-tabs/safe-area-prod.json
  • verification/desktop/evidence/905-privacy-tabs/settings-dev.json
  • verification/desktop/evidence/905-privacy-tabs/settings-prod.json
  • verification/desktop/evidence/905-privacy-tabs/smoke-prod.json
  • verification/desktop/evidence/905-privacy-tabs/unsupported-production-fixtures.json
  • verification/desktop/fixtures/native-hooks-on/main.tsx
  • verification/desktop/scripts/settings-page.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Claude and Codex native-hook settings move from Access to a dedicated Native hooks tab under Privacy & Permissions. The catalogue, tab UI, tests, browser verification, and supporting evidence are updated to reflect the new placement.

Changes: Privacy native hooks

Layer / File(s) Summary
Catalogue and tab placement
src/desktop/settings/model/settings-catalogue.ts, src/desktop/settings/ui/settings-tabs.tsx, src/desktop/settings/ui/native-hooks-rows.tsx, src/desktop/settings/adapters/native-hooks-gateway.ts, src/desktop/settings/index.ts
The catalogue assigns Claude and Codex hook settings to a new Native hooks tab. The tab renders the existing hook rows, while Access no longer renders them. Comments and the architecture label reflect the new location.
Placement and search validation
src/desktop/settings/model/settings-catalogue.test.ts, src/desktop/settings/ui/settings-view.test.tsx, src/desktop/settings/ui/native-hooks-rows.test.tsx, verification/desktop/CHECKLIST.md, verification/desktop/fixtures/native-hooks-on/main.tsx, verification/desktop/scripts/settings-page.mjs
Tests check tab assignment, search results, Access contents, and disabled hook rows. The desktop checklist and browser script check the Native hooks tab and search routing.
Desktop verification evidence
verification/desktop/evidence/905-privacy-tabs/*
Verification notes and browser-result records document successful and failed checks, viewport measurements, test conditions, and recorded limitations.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 4e306

The documented fold result is correct, and no actionable issue remains from this review. Normal pending checks can continue before merge.

Pre-merge checks: Passed 2 · Failed 3

Failed Failed checks: 3 warnings

Check name Status Explanation Resolution
Linked Issues check Warning For [#905], the implementation meets the tab-placement requirements. Both hook settings use the native-hooks catalogue route, NativeHooksRows renders on that tab, Access retains the common control… Run and record the combined #902+#905 functional matrix and scripted end-to-end verification at the reviewed head. Resolve any failures before completing the linked-issue requirements.
Docstring Coverage Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 10 files. (12 skipped:… Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check Warning The description provides detailed motivation, implementation, validation, limitations, and evidence links. It does not include the required "## Scripted gateway checks" section or the summary and evid… Add the required "## Scripted gateway checks" section. Include the pnpm test:e2e:scripted summary and link its evidence directory, or document the command result and the reason it remains pending.
Passed Passed checks: 2 passed
Check name Status Explanation
Out of Scope Changes check Passed The source changes, tests, comments, checklist updates, and verification records support [#905]. The gateway and module comment edits document the new Settings path without changing behavior. No unrel…
Title check Passed The title clearly and concisely describes the main change: moving native hooks to a dedicated Privacy tab.
Full details: Linked Issues check

Explanation

For [#905], the implementation meets the tab-placement requirements. Both hook settings use the native-hooks catalogue route, NativeHooksRows renders on that tab, Access retains the common controls, and the hook states and descriptions remain covered. Added tests cover catalogue routing, search destinations, rendered placement, and Access exclusion. The reported Chromium/WebKit checks cover the fold, lifecycle, focus, and reinsertion regression. The required combined #902+#905 functional matrix and scripted end-to-end verification remain pending, so the automated-test requirements are not complete.

Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 10 files. (12 skipped: 12 unsupported.)

Full details: Description check

Explanation

The description provides detailed motivation, implementation, validation, limitations, and evidence links. It does not include the required "## Scripted gateway checks" section or the summary and evidence link from pnpm test:e2e:scripted.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Varuas37

Copy link
Copy Markdown
Contributor Author

Scoped verification is complete at product/script source 6936cf2fc; current head 4e306c6bd adds the inspected screenshots and records only.

settings-page: 23/23 held (dev, both engines, all cases)
settings-page: 17/17 held (supported production cases, both engines)
smoke: 33/33 held (production, both engines/layouts)
safe-area: 19/19 held (production Settings checks)

Both engines put Access's last row at y587 in the 1000×700 viewport. Hook searches select Native hooks and reveal both rows. Production arrival is 220ms against 300ms, with no reduced-motion animations.

Reinserting only <NativeHooksRows /> on Access makes the unchanged masthead check fail in both engines:

1000x700 Privacy & Permissions: a row ends at y=739, below the fold

Restored exact source: masthead 3/3 held. Unit tests 312/312, typecheck/lint/format and fresh full source review are clean. Raw records, attribution and environment limitations preserve the earlier font-403 run and unsupported production-fixture attempt separately.

Access at 1000×700

Native hooks on its own tab

Draft remains pending the combined #902+#905 full matrix, scripted end-to-end verification, CI and external review. The historical MCP teardown failure's original cause remains unproved; this Settings fix does not diagnose it.

@Varuas37

Copy link
Copy Markdown
Contributor Author

@codex review
@coderabbitai review

Please review current head 4e306c6bd295bc37bf593ce554408425d15706cb against main abdaed37c1f0f89bdf819ae9debcc702e2705ad0. The Settings tab/routing repair has scoped unit/browser/probe evidence and a clean fresh source review. Evidence commits preserve source attribution and failed setup controls. The draft remains pending the full combined matrix now running at 25e621b37; no all-green or original MCP-cause claim is made.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T00:51:58.886079Z 4b33ce5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 4e306c6bd2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Varuas37

Copy link
Copy Markdown
Contributor Author

@codex review

Current head 4b33ce5 only formats two supplemental evidence JSON files after the frontend formatting failure. Parsed JSON values match the previously reviewed 4e306c6 head exactly; production, verifier and fixture sources are unchanged. Scoped Prettier and diff checks pass. The combined acceptance matrix still runs at 25e621b; current-head CI is pending.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 4b33ce5221

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Varuas37
Varuas37 marked this pull request as ready for review October 15, 2026 00:50

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@Varuas37
Varuas37 merged commit 4b7a2d0 into main Oct 15, 2026
10 of 11 checks passed
@Varuas37
Varuas37 deleted the codex/905-privacy-native-hooks-tab branch October 15, 2026 00:50
Varuas37 added a commit that referenced this pull request Oct 15, 2026
## Motivation

Closes #682. Reopening a panel chat in the desktop dropped image and
linked-file references from both committed and pending inputs.
Image-only messages became blank bubbles despite the gateway retaining
the metadata. The old restructure dependency is merged (#714/#715); this
change uses the current subscription-fed projection.

The structural correction is to give the desktop transcript a
reference-only attachment part and reuse the conversation owner's
mapping and renderer. The next adapter does not need to invent a second
attachment representation or renderer.

### Before

The desktop projection kept only input text.

```mermaid
flowchart LR
  Input[Gateway input with text and references] --> Projection[Desktop projection]
  Projection --> Text[Text-only user parts]
```

## Solution

1. `4395f3ce8`: retain image digest, encoding, size and linked path
through committed/pending projections; the reference collection is
readonly.
2. `4395f3ce8`: reuse `referencedContent` and `MessageImages` through
the public conversation boundary. Desktop input tiles show accessible
metadata placeholders without byte lookup; agent-published files keep
their existing read/save path.
3. `4395f3ce8`: cover image-only, file-only and mixed inputs, serialized
reads, fresh-source reopening and absence of read/save effects; register
a real Chromium/WebKit verifier and its contract.
4. `35bb18cf2`: settle request classification and leave diagnostic
reporting with the page session owner; an actual once-only console
witness and duplicate-reporter reversion prove one report per fault.

### Verifier diagnostic ownership

Two review findings in the same console component exposed duplicate
reporting: the check added its own result beside the page session's
existing reporter. The correction deletes the caller's report and keeps
the existing session owner, rather than copying or consuming its arrays
at another layer. `settleRequests` still completes classification before
close; existing line metadata carries the width. Production source is
unchanged.

| State or ordering | Owner and result |
| --- | --- |
| Browser records console/page/request error | Page session holds the
original line |
| Request classification is pending | Settle its report before deciding
whether the line is failure or harmless |
| Metadata assertions finish | They report their own facts without
copying diagnostic arrays |
| Page closes with retained lines | Shared close consumes and reports
each line once, then retires the context |
| Page has no retained lines | Close adds no redundant diagnostic result
|

The intermediate `08e6` duplicate witness remains preserved. The final
`35bb` witness emits one actual error per fresh context: one occurrence
in one console result per engine. Reintroducing only the duplicate
reporter gives two occurrences in two results per engine; both versions
still fail overall. The fixture and reporter were restored before final
checks.

### After

The original text and references reach the desktop message together;
rendering is derived from those retained references.

```mermaid
sequenceDiagram
  participant Gateway as Gateway view
  participant Projection as Desktop projection
  participant Message as Desktop message
  participant Tiles as Conversation reference tiles
  Gateway->>Projection: Original text, images and linked files
  Projection->>Message: Text and retained input references
  Message->>Tiles: Render metadata without conversation byte lookup
  Tiles-->>Message: Labelled image and linked-file placeholders
```

No persisted format, subscription ownership, authorization policy or
remote-fetch feature is added. Input references remain distinct from
files the agent published.

## Verification and remaining gates

Current source: `35bb18cf2f57164baae9c474b9ebe4e13f99052c` against main
`102cff8c4383b07e1fc34c695dabefa3c6d11c72`. Production, tests and
fixtures are unchanged from frozen `4395f3ce8`; the follow-up delegates
console reporting to its existing page owner. Fresh root R3 review of
all 19 paths at `35bb` is clean at every priority. Target main has
advanced through #880/#900; the local records retain their actual source
attribution.

- Final affected production suites at `4395f3ce8`: 305 tests / 13 files;
TypeScript, lint and format pass. The `35bb18cf2` verifier-only change
leaves those source/test/type paths unchanged.
- Full frontend tests: 4,593 / 346 before the final readonly-only
signature change and added renderer test; the latter and final affected
suite pass independently. Architecture, protocol, client docs/types and
production build pass.
- Removal probes: reverting projection loses metadata in all nine new
mapper cases; removing tiles fails all 18 quick browser cases; supplying
a conversation ID makes the no-fetch regression observe a read and fail.
- Actual final Chromium/WebKit: 109/109 checks (108 metadata scenarios
and the harmless-console result; six redundant success-only console
entries removed) at 360, 600 and 1440 pixels, including reopening.
Original encoding/size/path and adjacent punctuation survive; attachment
lists are labelled, metadata-only tiles have no image/action, and
surfaces remain within 1 pixel of horizontal overflow. Both screenshots
were inspected.

![Chromium retained
input](verification/desktop/evidence/user-attachments/chromium-restored-input.png)
![WebKit retained
input](verification/desktop/evidence/user-attachments/webkit-restored-input.png)

The signed-out scripted gateway run passes all three checks in both
engines:

| Check | Chromium | WebKit |
| --- | --- | --- |
| mcp-apps-gateway | pass | pass |
| gateway-window | pass | pass |
| scripted-scenarios | pass | pass |

The only final scripted console lines are the existing harmless favicon
404s and an aborted browser/check request after a 204 response (#485).

Scoped production timing at frozen `4395f3ce8` passes **8/8**,
calibrated at 4× CPU throttle, three fresh-page runs per
interaction/layout, with **zero frames over 50 ms**:

| Layout | Interaction | Max ms | Median ms |
| --- | --- | ---: | ---: |
| Columns | Send home | 35 | 34 |
| Columns | Typing | 24 | 22 |
| Columns | Stream one of four | 23 | 23 |
| Sidebar | Send home | 42 | 39 |
| Sidebar | Typing | 22 | 21 |
| Sidebar | Stream one of four | 28 | 25 |

```text
user-attachments: 109/109 held
perf-budget: 8/8 held
```

[Published source-attributed raw evidence and preserved
observations](https://github.com/nessalabs/nessa-agent/tree/3201a03a3642c19675d3b5d6ba10d7a5fcc52237/verification/desktop/evidence/user-attachments/4395f3ce).

The final frozen `4395f3ce8` functional matrix completed all 32 check
programs: 30 programs held; settings-page held 21/23 and MCP apps 92/93.
Settings masthead fails in both engines at 1000×700 (Privacy &
Permissions last row y766); the exact exported-main control reproduces
both failures, and separate #905 owns the repair. Separately tracked
#906: Chromium/sidebar app-initiated MCP teardown remained live and did
not close its pane/document. The full base sidebar sequence passes 24/24
and the current scenario retry passes 2/2; the original intermittent
cause remains unproved. This broad run is failed, not green. The four
documented message-sync retained-app production omissions are covered by
the separate dev check, 5/5 in both engines/layouts.

Final current-head attachment verifier holds 109/109, helper tests
191/191, scoped lint/format pass. A temporary single console.error per
context produces exactly one reported line/result per engine;
reintroducing the duplicate reporter produces two lines/results, while
both runs fail overall. Both transient edits were restored. All ten
workflow checks and CodeRabbit pass at current head `35bb18cf2`;
current-head Codex reports no major findings and both review threads are
resolved. The original full matrix and subsequent acceptance checks are
distinguished below. The original MCP cause remains tracked in #906.
Local acceptance is complete, with original failures and remaining
diagnostic uncertainty retained below.

Preserved initial observations: the first full frontend run failed the
unchanged ACP capture timing fixture (expected completed, received
failed); exported-main isolated control passes and the subsequent full
scripts suite passes 360 with two existing skips. The earlier broad
browser run is explicitly incomplete after a Chromium/columns
overview-count selector could-not-run; the exact whole-check
exported-main control passes 9/9, but the original timing cause remains
unproved. An initial scripted run failed on an aborted desktop.html
navigation; the sequential rerun passes, without a speculative product
fix or weakened assertion. Those records remain separate from final
acceptance.


### Combined acceptance status

The original 32-program matrix at clean assembly `25e621b37` completed
with 29 held, two unable to start without the built gateway, and one
message-sync frame failure (53.7ms/50ms). It remains an unsuccessful
original record. MCP apps 93/93, Settings 23/23 and user attachments
109/109 held; four retained-app cases were explicitly skipped by the
production sub-run.

Subsequent checks on the unchanged assembly close that coverage:

| Check | Result |
| --- | --- |
| Signed-out MCP apps gateway, both engines | 16/16 |
| Signed-out gateway window, both engines | 14/14 |
| Scripted scenarios, both engines | 9/9 |
| Mode publication after the source gateway build | 3/3 |
| Panel list follow after the source gateway build | 3/3 |
| Headed production message-sync, five runs per engine/layout | 23/23 |
| Dev retained-app coverage | 5/5 |
| Combined TypeScript check | Pass |

The headed control follows the desktop verification skill's
single-headless-outlier procedure: 20 fresh runs, calibrated 4x Chromium
and unthrottled WebKit, maximum frame 23ms with zero over-budget frames;
maximum delivery 35ms/600ms. The original 53.7ms scheduling cause and
historical MCP teardown cause remain unproved. No source or threshold
was changed to obtain the passing control.

[Source-attributed original matrix, follow-ups and merge
proof](https://github.com/nessalabs/nessa-agent/tree/1745fb6f351718f5fad42c8fe8bd1a5000e019ba/verification/desktop/evidence/797-followups/25e621b37)
retains the complete original JSON losslessly, plus readable summaries
and separate raw checks. This does not relabel the original matrix
green.

Current main `4b7a2d001` contains user-merged #907 and #886's
documentation updates. Its conflict-free prospective merge with exact
#902 head `35bb18cf2` yields tree
`25737ac9775cb254ae1818f94c88faf79b40b932`. Compared with the checked
assembly, only three #886 documentation files and two #907 equivalent
JSON formatting records differ; every other path is identical. Both
heads' current hosted CI/reviews are green; #907 has already merged.

## Scripted gateway checks

`node verification/desktop/scripts/scripted-e2e.mjs --mode dev
--evidence /tmp/nessa-797-902-907-scripted-final --channel chrome` at
`25e621b37` builds the actual gateway and runs signed out in Chromium
and WebKit. Verdict: **pass** (16/16 MCP apps, 14/14 gateway window, 9/9
scenarios).
[Evidence](https://github.com/nessalabs/nessa-agent/tree/1745fb6f351718f5fad42c8fe8bd1a5000e019ba/verification/desktop/evidence/797-followups/25e621b37).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Desktop conversation transcripts now preserve and display image and
linked-file attachment references alongside message text, including in
committed, pending, and reopened conversations.
* Attachment placeholders display available metadata without reading or
saving file contents. Agent-published files retain their separate read
and save behavior.
* **Bug Fixes**
* Reopening a conversation now retains its original text and image and
file attachment references.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings: keep Privacy Access controls above the fold

1 participant