Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds clarifying documentation to explain the difference between HConfig.merge() and HConfig.future() methods, addressing issue #155. The documentation helps users understand when to use each method and what to expect from their behavior.
- Adds a new section in
future-config.mdexplaining the distinct purposes ofmerge()vsfuture() - Adds a note in
custom-workflows.mdexplainingmerge()'s strict behavior and when to usefuture()instead - Includes minor formatting fixes to code blocks
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/future-config.md | Adds new section explaining merge() vs future(), clarifying that merge() is strict and raises DuplicateChildError for overlapping sections while future() allows overlapping configuration |
| docs/custom-workflows.md | Adds contextual note about merge() behavior with link to future() documentation; updates code block syntax highlighting to text for output examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #155