You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding CLI functionality to the package is very very easy and will not require a different package (as suggested on #186). It pretty much just requires one more module and some boilerplate in setup.py.
Good question. It won't be hard to make the CLI commands accept a variable number of parameters using argparse. The problem I think will be with the naming of all the parameters. We don't want something like this
when both num_eigs and eigenvalues are doing the exact same thing. So jointly with this we would have to implement a fairly major review and standardization of parameters.
On Wed, Jun 12, 2019 at 2:38 PM Stefan McCabe ***@***.***> wrote:
Flagging that this almost certainly can't be developed at the same time as
#174 <#174>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#197?email_source=notifications&email_token=AAILYADKVGRKJBVJDCN46O3P2E7DTA5CNFSM4HOPJSUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXRM4EA#issuecomment-501403152>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAILYAENODROLIPBJW3RPLTP2E7DTANCNFSM4HOPJSUA>
.
--
www.leotrs.com | leo@leotrs.com
PhD student at the Network Science Institute, Northeastern University
Activity
leotrs commentedon May 21, 2019
Adding CLI functionality to the package is very very easy and will not require a different package (as suggested on #186). It pretty much just requires one more module and some boilerplate in
setup.py.sdmccabe commentedon May 22, 2019
How do parameters work, given that each method has different ones? Still
--param?leotrs commentedon May 23, 2019
Good question. It won't be hard to make the CLI commands accept a variable number of parameters using
argparse. The problem I think will be with the naming of all the parameters. We don't want something like thiswhen both
num_eigsandeigenvaluesare doing the exact same thing. So jointly with this we would have to implement a fairly major review and standardization of parameters.sdmccabe commentedon May 23, 2019
I guess that can be our post-NetSci breaking change.
sdmccabe commentedon Jun 12, 2019
Flagging that this almost certainly can't be developed at the same time as #174.
leotrs commentedon Jun 12, 2019