Skip to content

Graph edit distances #227

Closed
Closed

Description

@sdmccabe

Perhaps we should have a more general NetSci postmortem, but one specific piece of feedback I got was a request for more graph edit distances. I think we avoided these because we already had Hamming distance, but we should definitely consider a more general GED implementation.

Activity

  1. leotrs commented on Jun 4, 2019

    @leotrs
    Collaborator

    First step is to compile a list of edit distances to implement. NetworkX has one, yes?

  2. sdmccabe commented on Jun 4, 2019

    @sdmccabe
    CollaboratorAuthor

    They do. Before the collabathon we had also flagged this survey paper as potentially useful.

  3. leotrs commented on Jun 4, 2019

    @leotrs
    Collaborator

    Is this the kind of thing that we can implement a single monolithic edit distance and parameterize the hell out of it?

  4. sdmccabe commented on Jun 4, 2019

    @sdmccabe
    CollaboratorAuthor
  5. added this to the 1.0 milestone on Oct 29, 2019
  6. sdmccabe commented on Jan 14, 2020

    @sdmccabe
    CollaboratorAuthor

    Coming around to the idea that we should just not implement this. It would just be a wrapper around NetworkX's graph edit distance, and since this library is already built on top of NetworkX, the value-add is pretty low. The benefit is a consistent interface, but is that worth it? It's not like it's that complicated an interface anyway.

  7. leotrs commented on Jan 14, 2020

    @leotrs
    Collaborator

    Fair. I guess we can close this for now until there is demand?

  8. leotrs commented on Jan 14, 2020

    @leotrs
    Collaborator

    It also opens a whole nother can o worms: does netrd want to implement ALL distances, regardless of whether or not they are accessible through other means?

  9. sdmccabe commented on Jan 14, 2020

    @sdmccabe
    CollaboratorAuthor

    I think it's a reasonable goal to have netrd implement as many as possible while acknowledging that all is basically impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions