Remove deprecated prestissimo composer plugin#369
Merged
Conversation
come-nc
requested review from
danxuliu,
juliusknorr,
nickvergessen and
skjnldsv
vinicius73
approved these changes
Mar 30, 2022
Collaborator
Author
|
It does not build, there are old dependencies in the composer.json in tests/acceptance/composer.json and build/integration/composer.json. Not sure how to update those cleanly and why they exists and contain so much things? |
Collaborator
Author
miaulalala
approved these changes
Mar 30, 2022
Collaborator
Author
|
/rebase |
1 similar comment
Collaborator
Author
|
/rebase |
come-nc
force-pushed
the
fix/remove-deprecated-composer-plugin
branch
from
da0d721 to
6b86801
Compare
hirak/prestissimo README says: This plugin is for Composer1; Composer2 is very fast on its own. Uninstall this plugin and update the Composer itself. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/remove-deprecated-composer-plugin
branch
from
6b86801 to
2421e26
Compare
Collaborator
Author
|
/rebase |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/remove-deprecated-composer-plugin
branch
from
d4e86f0 to
3f3375a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hirak/prestissimo README says:
This plugin is for Composer1;
Composer2 is very fast on its own.
Uninstall this plugin and update the Composer itself.
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com