Skip to content

Update pecl extensions in update.sh#543

Merged
J0WI merged 1 commit into
nextcloud:masterfrom
J0WI:pecl-update
Mar 14, 2019
Merged

Update pecl extensions in update.sh#543
J0WI merged 1 commit into
nextcloud:masterfrom
J0WI:pecl-update

Conversation

@J0WI

@J0WI J0WI commented Nov 21, 2018

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread update.sh
@tilosp

tilosp commented Nov 21, 2018

Copy link
Copy Markdown
Member

I generally like the idea of automating this.

But this would cause a lot of confusing commits.
For example if the redis version is updated, we would get mutiple commits from the jenkins server that runs update.sh.
And they would be called Update to 14.0.3, Update to 13.0.7 and Update to 12.0.12.

The code that generates the commits is here https://github.com/docker-library/oi-janky-groovy/blob/master/update.sh/target-pipeline.groovy

@J0WI

J0WI commented Nov 21, 2018

Copy link
Copy Markdown
Contributor Author

Yes, that would be the tradeoff. It's hard to change target-pipeline.groovy in a way that does not affects other repositories and I don't know if @tianon would accept such a specific change request.
See also docker-library/openjdk#246

@tilosp

tilosp commented Nov 21, 2018

Copy link
Copy Markdown
Member

We could also use a different solution for running the update.sh script.
Especially because the current jenkins script does not handle deleted file and updates to travis.yml. See: docker-library/oi-janky-groovy#8

Maybe something similar to what i am doing for generate-stackbrew-library.sh.

@tilosp

tilosp commented Nov 21, 2018

Copy link
Copy Markdown
Member

Btw there were also some wired commits in this repo ab3b62b...f16c857

@tilosp

tilosp commented Mar 13, 2019

Copy link
Copy Markdown
Member

@J0WI update.sh is now done by @tilosp-bot (see for example #662) so this should be possible now

@J0WI J0WI self-assigned this Mar 13, 2019
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
Comment thread update.sh

@tilosp tilosp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J0WI
J0WI merged commit ae8992a into nextcloud:master Mar 14, 2019
@J0WI
J0WI deleted the pecl-update branch March 14, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants