Add export/import functionality for forms #1425#3380
Conversation
88628b8 to
87bfc7c
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@timedin-de Please don't merge the main branch into your branch, always rebase your's on main. Also please sign-off your commits. |
5a575cf to
c5fb19b
Compare
|
@Chartman123 i dont think i did merge the main branch into mine, did sth slip through? Yes, will do, sorry for forgetting it everytime ^^ |
9c27a97 to
958c585
Compare
|
Now the history looks clean, don't now what it was then... |
958c585 to
b24065c
Compare
Signed-off-by: TimedIn <git@timedin.net>
b24065c to
992e49d
Compare
Signed-off-by: TimedIn <git@timedin.net>
992e49d to
87a5043
Compare
Chartman123
left a comment
There was a problem hiding this comment.
I've had a quick look at the PR and added a few comments :)
|
@Chartman123 i added the fixup commits for your comments, i'll rebase them if you accept them One other thing I would improve is validation/sanitasation of import/export. I'd make whitelist for allowed properties and remove others (or fail the request?) and copy the validations for questions: areExtraSettingsValid and |
building export and import via json
Download Button:
#1425