Sharebymail: set expiration on creation#25927
Merged
Merged
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst,
MorrisJobke,
icewind1991,
juliusknorr and
nickvergessen
PVince81
approved these changes
Mar 4, 2021
PVince81
left a comment
PVince81
left a comment
Member
There was a problem hiding this comment.
👍 code makes sense.
I see that in update it's already stored.
Guess the frontend probably doesn't use this either.
Member
Author
Nah you first create it and then set it. |
ChristophWurst
approved these changes
Mar 4, 2021
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
Workflow on all clients is to first share via mail and then add those options (expiration date, password, etc.) in a second step. But thanks, once/if we change the workflow, we can use this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tobiasKaminsky now sure if this is used by clients at all? But they can now.