Skip to content

Allow sub-admins to access delegated settings.#30926

Merged
artonge merged 1 commit into
nextcloud:masterfrom
rotdrop:bugfix/settings-delegation-for-subadmins
Jan 31, 2022
Merged

Allow sub-admins to access delegated settings.#30926
artonge merged 1 commit into
nextcloud:masterfrom
rotdrop:bugfix/settings-delegation-for-subadmins

Conversation

@rotdrop

@rotdrop rotdrop commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Close #30927

@szaimen szaimen requested review from a team, CarlSchwan, artonge, blizzz and icewind1991 and removed request for a team January 31, 2022 06:43
@szaimen szaimen added 3. to review Waiting for reviews enhancement labels Jan 31, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Jan 31, 2022
@artonge

artonge commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

@rotdrop your commit needs DCO :)

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
@rotdrop rotdrop force-pushed the bugfix/settings-delegation-for-subadmins branch from e9eb74e to a234217 Compare January 31, 2022 13:09
@rotdrop

rotdrop commented Jan 31, 2022

Copy link
Copy Markdown
Contributor Author

OK, I have signed the commit and force-pushed it to my fork.

@artonge

artonge commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

CI failure unrelated

@artonge artonge merged commit b47a42f into nextcloud:master Jan 31, 2022
@welcome

welcome Bot commented Jan 31, 2022

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@artonge

artonge commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

Thanks @rotdrop ! :)

@CarlSchwan

Copy link
Copy Markdown
Member

/backport to stable23

@gmaxbass

Copy link
Copy Markdown

Hi, I've a similar need: letting a sub admin promote a normal user to sub admin (sub admin delegation) within the same group.
I'm wondering if this pull-request covers this case delegating a sub-admin to administer only specific group(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SubAdmins cannot access delegated admin settings???

5 participants