Skip to content

Fix duplicated UUID detection when there are empty uuids#31491

Merged
come-nc merged 2 commits into
masterfrom
fix/user_ldap-fix-duplicated-empty-uuid-migration
Mar 10, 2022
Merged

Fix duplicated UUID detection when there are empty uuids#31491
come-nc merged 2 commits into
masterfrom
fix/user_ldap-fix-duplicated-empty-uuid-migration

Conversation

@come-nc

@come-nc come-nc commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc come-nc self-assigned this Mar 8, 2022
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/user_ldap-fix-duplicated-empty-uuid-migration branch from 4ab711c to 65a8665 Compare March 8, 2022 10:58
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Mar 8, 2022
@come-nc come-nc added this to the Nextcloud 24 milestone Mar 8, 2022

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we cover that through tests?

@come-nc

come-nc commented Mar 10, 2022

Copy link
Copy Markdown
Contributor Author

/backport to stable23

@come-nc

come-nc commented Mar 10, 2022

Copy link
Copy Markdown
Contributor Author

/backport to stable22

@come-nc

come-nc commented Mar 10, 2022

Copy link
Copy Markdown
Contributor Author

/backport to stable21

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@come-nc

come-nc commented Mar 10, 2022

Copy link
Copy Markdown
Contributor Author

Could we cover that through tests?

Not that easily and not in a useful way I think.

@come-nc come-nc merged commit 53e30c4 into master Mar 10, 2022
@come-nc come-nc deleted the fix/user_ldap-fix-duplicated-empty-uuid-migration branch March 10, 2022 17:16
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants