Fix reading blob data as resource#33129
Merged
Merged
Conversation
tcitworld
added
bug
3. to review
tcitworld
requested review from
a team,
ChristophWurst,
PVince81,
blizzz,
come-nc and
nickvergessen
and removed request for
a team
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
Author
|
@szaimen If you can try this patch |
ChristophWurst
approved these changes
Jul 6, 2022
Member
|
Can we get a test added? |
tcitworld
force-pushed
the
fix-reading-blob-as-resources
branch
2 times, most recently
from
fdab572 to
be520d7
Compare
Member
Author
|
There you go |
nickvergessen
approved these changes
Jul 6, 2022
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
I actually meant a real test reading stuff from the database, but fine by me for now
Member
Author
|
Where would I create such a functional test? Still in |
Member
|
Yes, tests/lib/AppFramework/DB/EntityTest.php |
blizzz
added
4. to release
Member
|
Linter is unhappy |
tcitworld
force-pushed
the
fix-reading-blob-as-resources
branch
from
be520d7 to
89c543f
Compare
Member
Author
|
Made it happy |
Contributor
|
Possible performance regression detected Show Output |
nickvergessen
approved these changes
Jul 11, 2022
come-nc
approved these changes
Jul 11, 2022
Member
|
/compile amend / |
nextcloud-command
force-pushed
the
fix-reading-blob-as-resources
branch
from
89c543f to
6f65b50
Compare
Member
Author
|
Why the compile amend? :( |
PostgreSQL returns data as resource when using IQueryBuilder::PARAM_LOB (which is used for QBMapper). Previously we just converted this resource using settype, which produced things like "Resource id #14" instead of the actual resource data. Now we read the stream correctly if the returned data is a resource See context at #22472 Fixes #22439 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
nickvergessen
force-pushed
the
fix-reading-blob-as-resources
branch
from
6f65b50 to
1d30fb7
Compare
Member
|
It was just the wrong command, I guess he wanted to rebase because that is what github complained about. |
Member
|
yeah, sorry, was rushing through review requests |
This was referenced Jul 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL returns data as resource when using
IQueryBuilder::PARAM_LOB(which is used for QBMapper).Previously we just converted this resource using
settype, which produced things like"Resource id #14"instead of the actual resource data.Now we read the stream correctly if the returned data is a resource
See context at #22472
Fixes #22439