Skip to content

Bump doctrine/dbal to 3.5.1 in master#35084

Closed
come-nc wants to merge 1 commit into
masterfrom
fix/bump-doctrine/dbal-to-3.5.1-in-master
Closed

Bump doctrine/dbal to 3.5.1 in master#35084
come-nc wants to merge 1 commit into
masterfrom
fix/bump-doctrine/dbal-to-3.5.1-in-master

Conversation

@come-nc

@come-nc come-nc commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc self-assigned this Nov 10, 2022
@come-nc come-nc added this to the Nextcloud 26 milestone Nov 10, 2022

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen

Copy link
Copy Markdown
Member

Error: lib/private/DB/Connection.php:127:12: InternalMethod: The method Doctrine\DBAL\Connection::connect is internal to Doctrine but called from OC\DB\Connection

🪦

@come-nc

come-nc commented Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

lib/private/DB/Connection.php:127:12

@nickvergessen Do we have any other choice than to ignore those errors?
From what I understand real changes will only happen with dbal 4.x.

Should I add those Internal* errors to the baseline?

(Note that there is also a test error that needs to be looked into)

@come-nc

come-nc commented Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

ref: https://github.com/doctrine/dbal/blob/3.5.x/UPGRADE.md

A lot of things got deprecated or marked as internal

This was referenced Nov 15, 2022
@come-nc come-nc closed this Nov 21, 2022
@skjnldsv skjnldsv deleted the fix/bump-doctrine/dbal-to-3.5.1-in-master branch March 14, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants