fix(JSResourceLocator): Handle missing translations silently#38207
Merged
Conversation
susnux
requested review from
a team,
ArtificialOwl,
artonge,
come-nc and
nfebe
and removed request for
a team
susnux
force-pushed
the
fix/jsresourcelocator-l10n-handling
branch
from
a88b51e to
4efef1c
Compare
artonge
approved these changes
May 11, 2023
come-nc
reviewed
May 11, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/jsresourcelocator-l10n-handling
branch
from
4efef1c to
31c01fa
Compare
skjnldsv
approved these changes
May 12, 2023
skjnldsv
added
4. to release
Merged
Member
|
Seems this may introduce broken instances after upgrade, possible fix is in #38237 |
This was referenced Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that even if no app path could be loaded, missing translations are handled silently and no error is logged in that case.
I have also added a test case for the linked issue.
Checklist