Skip to content

Fix user log.condition feature#38881

Merged
come-nc merged 1 commit into
masterfrom
fix/logcondition-user
Jun 26, 2023
Merged

Fix user log.condition feature#38881
come-nc merged 1 commit into
masterfrom
fix/logcondition-user

Conversation

@come-nc

@come-nc come-nc commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Summary

User is not alway known at first log of a request, so we cannot cache log condition be request before we know the user.

Checklist

@come-nc come-nc added bug 3. to review Waiting for reviews labels Jun 19, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Jun 19, 2023
@come-nc come-nc self-assigned this Jun 19, 2023
@szaimen szaimen requested review from a team, blizzz, icewind1991 and nfebe and removed request for a team June 22, 2023 12:09

@nfebe nfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshtrichards

Copy link
Copy Markdown
Member

This seems to work much better...

@come-nc

come-nc commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

/backport to stable27

@come-nc

come-nc commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

/backport to stable26

@come-nc

come-nc commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

/backport to stable25

@come-nc come-nc force-pushed the fix/logcondition-user branch from a014cf0 to 6b9de1a Compare June 26, 2023 08:05
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/logcondition-user branch from 6b9de1a to 8ed6086 Compare June 26, 2023 08:07
@come-nc come-nc requested a review from artonge June 26, 2023 08:08
@come-nc come-nc enabled auto-merge June 26, 2023 12:35
@come-nc come-nc disabled auto-merge June 26, 2023 15:25
@come-nc come-nc merged commit 2d81c04 into master Jun 26, 2023
@come-nc come-nc deleted the fix/logcondition-user branch June 26, 2023 15:25
@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: log.condition does not work per user!

4 participants