Skip to content

feat(contactsinteraction): allow users to disable contacts interaction addressbook#39372

Closed
tcitworld wants to merge 1 commit into
masterfrom
contctsinteraction-usersetting
Closed

feat(contactsinteraction): allow users to disable contacts interaction addressbook#39372
tcitworld wants to merge 1 commit into
masterfrom
contctsinteraction-usersetting

Conversation

@tcitworld

@tcitworld tcitworld commented Jul 13, 2023

Copy link
Copy Markdown
Member

This allows simple users to opt-out of the contacts interaction addressbook even if admins have the app installed.

Similar to how the birthday calendar works, the functionnality can be toggled in the user's settings or by doing a DELETE on the addressbook.

A new contacts personal section has been added to contain this new setting.

TODO

  • moar tests

Checklist

Comment thread apps/contactsinteraction/lib/DAV/Plugin.php Fixed
*
* @param Server $server
*/
public function initialize(Server $server) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\ContactsInteraction\DAV\Plugin::initialize does not have a return type, expecting void
Comment thread apps/settings/lib/Sections/Personal/Calendar.php Outdated
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@HLFH

HLFH commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

@tcitworld But what if I like this addressbook, and I only need to delete one contact from this addressbook. Let's say I have sent an email to a non-existent address, I get a bounce-back NDR email, and the non-existent contact goes into the "Recently contacted" addressbook, but because the email address is invalid, I want to delete it, while still enjoying the "Recently contacted" addressbook. This PR seems to solve only 50% of the current issue we have with this addressbook. I think deleting/disabling the whole addressbook does not address the described issue I have.

@tcitworld

Copy link
Copy Markdown
Member Author

@HLFH We will keep the issue opened for this specific aspect

@tcitworld tcitworld force-pushed the contctsinteraction-usersetting branch from c43c995 to b6710f4 Compare February 1, 2024 17:36
@tcitworld

Copy link
Copy Markdown
Member Author

Rebased

@st3iny st3iny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting the address book from the Contacts app didn't work. The DELETE request itself worked and the address book vanishes until the next page reload. It will still contain all of its former contacts after the page reload.

Disabling it via the personal settings works. However, the address book is still shown in the Contacts settings modal (with 0 contacts and 0 groups) afterwards.

@tcitworld tcitworld added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 13, 2024
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
@susnux

susnux commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Hello 👋
currently here have been no activity in the last years.
If this is still actual feel free to reopen the pull request and resolve the conflicts so we can incorporate it into Nextcloud.
Thank you very much for your contribution!

@susnux susnux closed this Jun 9, 2026
@ChristophWurst ChristophWurst deleted the contctsinteraction-usersetting branch June 10, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress community pull requests from community feature: carddav Related to CardDAV internals feature: contacts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show/hide "recently contacted"

10 participants