Correct semantics for link opening in global search#42062
Merged
Conversation
artonge
approved these changes
Dec 6, 2023
susnux
reviewed
Dec 6, 2023
Following the update of `NcListItem` to allow control over where and how passed `hrefs` open, the search result component can now make use of these props. See : nextcloud-libraries/nextcloud-vue#4923 Resolves : #41800 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe
force-pushed
the
use-href-for-search-results
branch
from
de1601b to
aa25590
Compare
Contributor
Author
|
/compile |
susnux
approved these changes
Dec 6, 2023
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Member
|
/backport to stable28 |
Contributor
Author
|
Everything green except |
Member
|
/backport to stable28 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the update of
NcListItemto allow control over where and how passedhrefsopen, the search result component can now make use of these props.See : nextcloud-libraries/nextcloud-vue#4923
Resolves : #41800