movie preview bug fix, in some case stream reading functions may block indefinitely#43226
Conversation
blizzz
left a comment
There was a problem hiding this comment.
From the documentation:
In non-blocking mode an fgets() call will always return right away while in blocking mode it will wait for data to become available on the stream.
Could be more exhaustive. Is it possible that we only receive incomplete data with this setting?
|
@jpsn123 thanks for the adaptions! Would you mind rebasing one more time? |
|
@jpsn123 sorry for the delay here. Can you sign off your commit? git rebase HEAD~1 --signoff
git push --force-with-lease origin masterThen we should be good :) |
…ctions may block indefinitly Signed-off-by: cn-shell <jpsn@foxmail.com> Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
For some reason, I need to run nextcloud as root, and in this case ffmpeg will block the process when it generates preview.
refencese:
https://www.php.net/manual/en/function.proc-open.php#97012
https://www.php.net/manual/en/function.stream-get-contents.php#106905