fix: Do not try to set HTTP response code on already closed connection#47971
Merged
Merged
Conversation
This avoids a PHP warning in the logs about trying to set the response code while the output already started. It’s useless to try to print an error page anyway in this situation because the connection was closed already. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
come-nc
requested review from
a team,
Altahrim,
artonge,
icewind1991,
joshtrichards and
nfebe
and removed request for
a team
artonge
approved these changes
Sep 14, 2024
solracsf
approved these changes
Sep 14, 2024
Altahrim
approved these changes
Sep 14, 2024
joshtrichards
approved these changes
Sep 14, 2024
This was referenced Sep 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This avoids a PHP warning in the logs about trying to set the response
code while the output already started. It’s useless to try to print an
error page anyway in this situation because the connection was closed
already.
Checklist