fix(setupchecks): Treat information messages as success#51675
Merged
SystemKeeper merged 2 commits intoMar 24, 2025
Conversation
SystemKeeper
requested review from
Pytal,
susnux and
szaimen
and removed request for
a team
szaimen
approved these changes
Mar 24, 2025
szaimen
left a comment
szaimen
left a comment
Contributor
There was a problem hiding this comment.
Great idea, thanks! :)
LGTM based on the screenshots but did not test and did not review the code
szaimen
added
enhancement
design
susnux
approved these changes
Mar 24, 2025
nickvergessen
approved these changes
Mar 24, 2025
Member
|
/compile |
Contributor
Author
|
/compile rebase |
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/noid/accept-informational-tests-as-success
branch
from
442346c to
250ec29
Compare
Contributor
Author
|
/backport 86ae30d to stable31 |
1 task
Contributor
Author
|
/backport 86ae30d to stable30 |
1 task
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we treat any message at least as a failure. If there are only informational items, we should not treat them as a failure, otherwise they should be warnings.
Before:
After:
Checklist