fix: Remove deprecated getters in IServerContainer#52848
Merged
Conversation
Contributor
Author
|
It’s breaking circles because its share provider is not DI compatible, will have to fix that first. |
… anymore For now I left the ones which are called from lib/ Next step is to fix all calls and remove those as well. Also the getters should be removed from the implementation. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…recated getters Ideally circles and talk should migrate to calling registerProvider and core would not need to use their OCA classes like currently. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ed from public interface Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ests Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/cleanup-servercontainer
branch
from
3c23ffa to
2419f4b
Compare
This is to avoid issues if the circles app is disabled but you still have circles shares in your DB Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
come-nc
added
3. to review
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/cleanup-servercontainer
branch
from
9c8f493 to
70ef0a8
Compare
come-nc
requested review from
artonge,
provokateurin,
skjnldsv and
yemkareems
and removed request for
a team
Contributor
Author
|
Once this is merged we can merge nextcloud/circles#1996 on circles side to fix compatibility. |
susnux
added
the
pending documentation
Contributor
|
@come-nc remember to document the removal in the documentstion |
Contributor
Author
|
pending documentstion |
Merged
come-nc
removed
the
pending documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated getters from IServerContainer which are unused in current known code.
Remove those from Server class implementation, along with some that were already gone from the interface.
Cleaned up share provider factory as it was using some of those.
TODO
Checklist