Skip to content

feat: Add Shift-Mod-C for copying the markdown source#3941

Merged
juliusknorr merged 2 commits into
mainfrom
enh/copy-markdown
Mar 14, 2023
Merged

feat: Add Shift-Mod-C for copying the markdown source#3941
juliusknorr merged 2 commits into
mainfrom
enh/copy-markdown

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Mar 14, 2023

Copy link
Copy Markdown
Member

Signed-off-by: Julius Härtl jus@bitgrid.net

📝 Summary

See title, should make our lives easier when copying stuff to other areas that need markdown.

Note this only works in a secure browser context (when using HTTPS)

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added enhancement New feature or request 3. to review labels Mar 14, 2023
@juliusknorr juliusknorr added this to the Nextcloud 27 milestone Mar 14, 2023
@cypress

cypress Bot commented Mar 14, 2023

Copy link
Copy Markdown

1 flaky tests on run #9047 ↗︎

0 136 1 0 Flakiness 1

Details:

feat: Add Shift-Mod-C for copying the markdown source
Project: Text Commit: 3d08ba2bc7
Status: Passed Duration: 04:02 💡
Started: Mar 14, 2023 1:16 PM Ended: Mar 14, 2023 1:20 PM
Flakiness  cypress/e2e/share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo- mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works like expected 🎉

@juliusknorr

Copy link
Copy Markdown
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr juliusknorr merged commit 7741ade into main Mar 14, 2023
@juliusknorr juliusknorr deleted the enh/copy-markdown branch March 14, 2023 15:16
@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-

mejo- commented Mar 14, 2023

Copy link
Copy Markdown
Member

/backport 3aab433 to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-

mejo- commented Mar 14, 2023

Copy link
Copy Markdown
Member

/backport 3aab433 to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

@mejo-

mejo- commented Mar 14, 2023

Copy link
Copy Markdown
Member

Manual backport to stable26: #3942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review backported successfully backported enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants