feat(editor): Enable gapcursor, allows to put cursor between images#5095
Merged
Conversation
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Fixes: #3427 Signed-off-by: Jonas <jonas@freesources.org>
max-nextcloud
approved these changes
Dec 6, 2023
max-nextcloud
left a comment
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
❤️ Thanks for looking into this!
Collaborator
|
This might also address some aspects of #3111 |
juliusknorr
approved these changes
Dec 6, 2023
juliusknorr
left a comment
juliusknorr
left a comment
Member
There was a problem hiding this comment.
🚀
(I need those nice test images as well 😁 🦖)
Member
Author
Unfortunately not yet. We might be able to configure the mentions node to allow gapcursor before it, but out of the box it's not possible. |
Member
Author
I love them 🦕 They're from https://prosemirror.net/examples/dino/ |
Member
Author
|
/backport to stable28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Enable gapcursor extension and remove workaround to add newlines between images when uploading more than one.
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)