Repository navigation
test: cover safeUrl and sanitizeUrl script-scheme guards - #345
Open
readyagentsdev wants to merge 1 commit into
Open
readyagentsdev wants to merge 1 commit into
readyagentsdev wants to merge 1 commit into
Conversation
Signed-off-by: Agent G <326687097+readyagentsdev@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #342.
Adds
tests/url-scheme-guards.test.js: table-driven tests forsafeUrl(src/safe-url.js) andsanitizeUrl(src/shared/sanitize-url.js). Tests only, no source changes.Covered
javascript:,data:,vbscript:in mixed casing and with leading whitespace fall back (default'#'and a custom fallback forsafeUrl)//hostis rejectedhttp(s)://, root-relative/path,#anchormailto:,.//../, trimming, andhttps:example.comwithout slashes, which onlysafeUrlaccepts)Not pinned, worth a look: both functions currently accept
/\evil.com. Browsers normalise a leading/\to//, so as anhrefthis navigates toevil.com. I left it out of the tests rather than locking in either behaviour, so you can decide whether it should be rejected.npx vitest run tests/url-scheme-guards.test.js: 102 passed.prettier --checkclean.